"Check your claim" page fixes #2375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 22, 2018 13:26
For interim claims, if disbursements only are supplied then update totals with disbursements totals before validations are performed so the validations work as expected and the user does not get blocked on the page with a total value claimed error when they have submitted the correct information.
LGFS interim claim do not have a warrant fee association but instead can have an interim fee which is of type warrant.
ghost
assigned
added 2 commits
May 22, 2018 16:46
disbursement section is actual part of the misc fees steps, so if it needs to be edited, the user will see the misc fees step.
CYC (Check Your Claim)
lostie
force-pushed
the
check-your-claim-page-fixes
branch
2 times, most recently
from
55bae7b to
2224907
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Relates to: #2340
Ticket
Check your claim page fixes
Some of these
NOTE: This PR does not include all the fixes for the ticket, as otherwise it would turn up to be a massive one again, so I'm trying to deliver small pieces at a time.