Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CCMSPUI-376: Migrate notification summary from SOA-API to EBS-API #312

Merged
merged 6 commits into from
Dec 9, 2024
Merged

CCMSPUI-376: Migrate notification summary from SOA-API to EBS-API #312

merged 6 commits into from
Dec 9, 2024

Conversation

JamieBriggs-MoJ
Copy link
Contributor

As part of CBP-947, work was done to move the notification summary from SOA to EBS, which resulted in a new view XXCCMS_NOTIFICATION_COUNT_V being created to support this.

As part of this PR and CCMSPUI-376, the old method in SoaApiClient has been removed, and a new method has been added in EbsApiClient to use the new endpoint added as part of this PR:
ministryofjustice/laa-ccms-data-api#119

@JamieBriggs-MoJ
CCMSPUI-376 Added notification summary method to EbsApiClient, remove…
fa6a538 
…d old method from SoaApiClient, and updated HomeController to correlate with these changes.

Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk>
@JamieBriggs-MoJ JamieBriggs-MoJ self-assigned this Dec 5, 2024
@JamieBriggs-MoJ
CCMSPUI-376 Added javadoc to EbsApiClient to fix checkstyle violation
806fffb 
Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk>
@JamieBriggs-MoJ
Copy link
Contributor Author

The class NotificationSummary is still being used from the SOA gateway API rather than the new one generated in the EBS API so leaving this PR as a draft. It would for myself to first understand what the process for releasing new versions of APIs is before updating the versions within this project's build.gradle.

farrell-m
farrell-m approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@farrell-m farrell-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved (subject to the NotificationsSummary model being updated)

@PhilDigitalJustice
Copy link
Contributor

Are you able to amend the gradle build with the snapshot versions:

uk.gov.laa.ccms.data:data-api:0.0.21-9a44d8f-SNAPSHOT
uk.gov.laa.ccms.soa.gateway:soa-gateway-api:0.0.38-cfdf45d-SNAPSHOT

Usually do this, then once this is merged, a PR is auto raised for the release version for ebs-api and soa-api.

PhilDigitalJustice
PhilDigitalJustice requested changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@PhilDigitalJustice PhilDigitalJustice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the 1 change to check first

@JamieBriggs-MoJ JamieBriggs-MoJ marked this pull request as ready for review December 9, 2024 11:16
@JamieBriggs-MoJ
CCMSPUI-376: Updated guild.gradle to include snapshot versions and up…
0c7d5cc 
…dated references to correct NotificationSummary package

Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk>
@JamieBriggs-MoJ
Copy link
Contributor Author

Are you able to amend the gradle build with the snapshot versions:

uk.gov.laa.ccms.data:data-api:0.0.21-9a44d8f-SNAPSHOT uk.gov.laa.ccms.soa.gateway:soa-gateway-api:0.0.38-cfdf45d-SNAPSHOT

Usually do this, then once this is merged, a PR is auto raised for the release version for ebs-api and soa-api.

@PhilDigitalJustice I have updated build.gradle properties to the published SNAPSHOT versions and updated references to NotificationSummary to the new EBS varient.

@JamieBriggs-MoJ
Merge branch 'main' into story/ccmspui-376-replace-soa-notification-s…
445ee35 
…ummary

# Conflicts:
#	src/main/java/uk/gov/laa/ccms/caab/controller/HomeController.java
@JamieBriggs-MoJ
CCMSPUI-376: Pulled main and resolved conflicts
be35c89 
Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk>
@JamieBriggs-MoJ
CCMSPUI-376: Removed old SoaApi test and added new EBS notification s…
54599f9 
…ummary tests

Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk>
@JamieBriggs-MoJ
Copy link
Contributor Author

After requesting review, realised the integration tests were not working due to old Soa method not existing anymore. Took the time to remove this, and also add the EBS integration tests for the new NotificationSummary endpoint as this was missed off initially.

PhilDigitalJustice
PhilDigitalJustice approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@PhilDigitalJustice PhilDigitalJustice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JamieBriggs-MoJ JamieBriggs-MoJ merged commit b456b16 into main Dec 9, 2024
1 check passed
@JamieBriggs-MoJ JamieBriggs-MoJ deleted the story/ccmspui-376-replace-soa-notification-summary branch December 9, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@farrell-m farrell-m farrell-m approved these changes

@PhilDigitalJustice PhilDigitalJustice PhilDigitalJustice approved these changes

Assignees

@JamieBriggs-MoJ JamieBriggs-MoJ

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JamieBriggs-MoJ @PhilDigitalJustice @farrell-m