CCMSPUI-376: Migrate notification summary from SOA-API to EBS-API #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamieBriggs-MoJ
changed the title
farrell-m
reviewed
Dec 6, 2024
data-service/src/main/java/uk/gov/laa/ccms/data/entity/NotificationCount.java
Outdated
Show resolved
Hide resolved
…being an inner class, and moved notification logic to NotificationsController and it's own services Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk>
Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk>
Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk>
I agree with this retrospectively. I have made some more changes to go in line with this and to decouple the notification summary stuff away from the User controller/service. |
JamieBriggs-MoJ
deleted the
story/ccmspui-376-replace-soa-notification-summary
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of CBP-947, work was done to move the notification summary from SOA to EBS, which resulted in a new view
XXCCMS_NOTIFICATION_COUNT_Vbeing created to support this.As part of this PR and CCMSPUI-376, a new endpoint has been created which uses the new view.