Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop yielding network in certain normalizers #3420

Merged
merged 7 commits into from
Sep 4, 2024

Conversation

originalsouth
Copy link
Contributor

Changes

Stop yielding network in certain normalizers

Issue link

N/A

Demo

N/A

QA notes

No specific changes in flow, good to check the affected normalizers (Nmap TCP).


Code Checklist

  • All the commits in this PR are properly PGP-signed and verified.
  • This PR only contains functionality relevant to the issue.
  • I have written unit tests for the changes or fixes I made.
  • I have checked the documentation and made changes where necessary.
  • I have performed a self-review of my code and refactored it to the best of my abilities.
  • Tickets have been created for newly discovered issues.
  • For any non-trivial functionality, I have added integration and/or end-to-end tests.
  • I have informed others of any required .env changes files if required and changed the .env-dist accordingly.
  • I have included comments in the code to elaborate on what is not self-evident from the code itself, including references to issues and discussions online, or implicit behavior of an interface.

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.


Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

@originalsouth originalsouth added boefjes Issues related to boefjes backend labels Aug 29, 2024
@originalsouth originalsouth requested a review from a team as a code owner August 29, 2024 09:19
ammar92
ammar92 previously approved these changes Aug 29, 2024
Copy link
Contributor

@ammar92 ammar92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe there's another one in boefjes/boefjes/plugins/kat_burpsuite/normalize.py

noamblitz
noamblitz previously approved these changes Aug 29, 2024
@originalsouth originalsouth dismissed stale reviews from noamblitz and ammar92 via f5e30d9 August 29, 2024 09:30
Copy link
Contributor

@dekkers dekkers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also use the network of the input OOI instead of hardcoding "internet" in kat_crt_sh, but that can also be done in a later PR.

@noamblitz
Copy link
Contributor

I believe there's another one in boefjes/boefjes/plugins/kat_burpsuite/normalize.py

That one could possibly stay there since burp has no input OOI

@underdarknl
Copy link
Contributor

We should also use the network of the input OOI instead of hardcoding "internet" in kat_crt_sh, but that can also be done in a later PR.

CRT.sh records can only ever be 'about' the internet, so not hardcoding it to that network wouldn't really change anything

@underdarknl underdarknl merged commit 175bdce into main Sep 4, 2024
11 checks passed
@underdarknl underdarknl deleted the fix/stop_yielding_network_in_certain_normalizers branch September 4, 2024 07:07
@originalsouth
Copy link
Contributor Author

@Donnype what is point of assigning this PR to me after it is merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend boefjes Issues related to boefjes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants