-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop yielding network in certain normalizers #3420
Stop yielding network in certain normalizers #3420
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe there's another one in boefjes/boefjes/plugins/kat_burpsuite/normalize.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also use the network of the input OOI instead of hardcoding "internet" in kat_crt_sh, but that can also be done in a later PR.
That one could possibly stay there since burp has no input OOI |
CRT.sh records can only ever be 'about' the internet, so not hardcoding it to that network wouldn't really change anything |
@Donnype what is point of assigning this PR to me after it is merged? |
Changes
Stop yielding network in certain normalizers
Issue link
N/A
Demo
N/A
QA notes
No specific changes in flow, good to check the affected normalizers (Nmap TCP).
Code Checklist
.env
changes files if required and changed the.env-dist
accordingly.Checklist for code reviewers:
Copy-paste the checklist from the docs/source/templates folder into your comment.
Checklist for QA:
Copy-paste the checklist from the docs/source/templates folder into your comment.