Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop yielding network in certain normalizers #3420

Merged
merged 7 commits into from
Sep 4, 2024
Merged

Stop yielding network in certain normalizers #3420

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1686d94
Stop yielding network in certain normalizers
originalsouth Aug 29, 2024
f5e30d9
Yield less in test
originalsouth Aug 29, 2024
299c3a8
Merge branch 'main' into fix/stop_yielding_network_in_certain_normali…
originalsouth Aug 29, 2024
af63d89
Merge branch 'main' into fix/stop_yielding_network_in_certain_normali…
underdarknl Aug 30, 2024
0e70776
Merge branch 'main' into fix/stop_yielding_network_in_certain_normali…
ammar92 Sep 3, 2024
cf269be
Merge branch 'main' into fix/stop_yielding_network_in_certain_normali…
ammar92 Sep 3, 2024
386e658
Merge branch 'main' into fix/stop_yielding_network_in_certain_normali…
ammar92 Sep 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion boefjes/boefjes/plugins/kat_crt_sh/normalize.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ def run(input_ooi: dict, raw: bytes) -> Iterable[NormalizerOutput]:
current = fqdn.lstrip(".")

network = Network(name="internet")
yield network
network_reference = network.reference

unique_domains = set()
Expand Down
1 change: 0 additions & 1 deletion boefjes/boefjes/plugins/kat_nmap_tcp/normalize.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ def run(input_ooi: dict, raw: bytes) -> Iterable[NormalizerOutput]:

# Relevant network object is received from the normalizer_meta.
network = Network(name=input_ooi["network"]["name"])
yield network

netblock_ref = None
if "NetBlock" in input_ooi["object_type"]:
Expand Down
2 changes: 1 addition & 1 deletion boefjes/tests/test_nmap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ class NmapTest(TestCase):
def test_normalizer(self):
input_ooi = IPAddressV4(network=Network(name="internet").reference, address="134.209.85.72")
output = list(run(input_ooi.serialize(), get_dummy_data("raw/nmap_mispoes.xml")))
self.assertEqual(16, len(output))
self.assertEqual(15, len(output))
for i, out in enumerate(output[:-1]):
if out.object_type == "IPPort" and output[i + 1].object_type == "Service":
if out.port == 80:
Expand Down