move Tcpip_stack_socket to Tcpip_stack_socket.V4, provide Tcpip_stack_socket.V6; also dual direct stack and fixes #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannesm
force-pushed
the
tcpip-stack-socket-v6
branch
from
ac95b40
to
663f5f8
Compare
|
travis is failing since this is an API-breaking change which needs updates to the mirage tool (there are some needed for #432 as well). i'd suggest to merge #432 and #433 (and an upcoming #434), cut a release (6.0.0 -- to avoid earlier mirage releases using the new, API-incompatible tcpip), and cut a mirage release (3.8.1). |
hannesm
force-pushed
the
tcpip-stack-socket-v6
branch
from
663f5f8
to
dea044b
Compare
hannesm
changed the title
hannesm
force-pushed
the
tcpip-stack-socket-v6
branch
from
c978861
to
a00400e
Compare
|
this now requires mirage/mirage-protocols#27 and mirage/mirage-stack#19, and fix some bugs:
|
hannesm
force-pushed
the
tcpip-stack-socket-v6
branch
from
561ec82
to
a00400e
Compare
|
moving forward, I first cut a 5.0.1 release (based on master, but reverting the API-breaking change of Ipv6.connect -- which mirage knows about). now we can figure the IPv6 out subsequently, break APIs and move to a 6.0.0 release. I pushed the 5.0.1 changes entry to master directly. |
hannesm
force-pushed
the
tcpip-stack-socket-v6
branch
from
9ae1f0c
to
890d978
Compare
|
now with |
hannesm
force-pushed
the
tcpip-stack-socket-v6
branch
from
75f0cca
to
9c59ea2
Compare
hannesm
commented
Oct 4, 2020
hannesm
force-pushed
the
tcpip-stack-socket-v6
branch
from
1bfb145
to
7e45588
Compare
provide Tcpip_stack_socket.V6 implementing Mirage_stack.V6
this has been changed in mirage-protocols 5.0.0 to allow dual stack
also set the same socket option to true in IPv6 only socket stack
this cleans up the interface (needs to be synced with the mirage tool)
The motivation is to unify the socket and direct stack configuration, and being able to reuse the same command line arguments.
hannesm
force-pushed
the
tcpip-stack-socket-v6
branch
from
7e45588
to
a04b6f7
Compare
dual stack: accept ipv4_only and ipv6_only arguments fix tests with revised API
Also, adapt the IP.mtu implementation to its interface: now ~dst:ipaddr is required. This allows the dual stack to provide appropriate numbers.
hannesm
force-pushed
the
tcpip-stack-socket-v6
branch
from
a04b6f7
to
8b84db2
Compare
hannesm
added a commit
to hannesm/opam-repository
that referenced
this pull request
Nov 30, 2020
CHANGES: * Dual IPv4 and IPv6 socket and direct stack support, now requires mirage-stack 2.2.0 and mirage-protocols 5.0.0 (mirage/mirage-tcpip#433 @hannesm) * The above change also unified arguments passed to connect functions which are API-breaking changes * IPv6 waits for timeout after sending neighbour advertisement (for duplicate address detection) * Remove Xen cross-compilation runes, with mirage-xen 6.0.0 they're provided by mirage-xen (mirage/mirage-tcpip#434 @hannesm) * Move to dune 2.7.0 (and bisect instrumentation if desired) (mirage/mirage-tcpip#436 @hannesm)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
..continuing the #431 ride.. //cc @MagnusS