Migrate to dune 2.7 and add bisect runes #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MagnusS do you have an idea why the "iperf with two stacks and uniform packet loss of packets with no payload" fails with: i.e. running in a timeout, esp. on the arm32 runner -- should we increase the timeout? (it is 120 seconds atm) |
hannesm
force-pushed
the
dune2
branch
2 times, most recently
from
8b99f26
to
dab2be1
Compare
|
(increasing the timeout for iperf did the trick, I disabled the ipv6 iperf test -- marked it as slow) |
|
anyone would like to review this? otherwise I'll go ahead merge, release, and fix up fallout |
as advertised on the bisect_ppx repository: dune runtest --instrument-with bisect_ppx --force bisect-ppx-report summary (or html) -> Coverage: 2232/3604 (61.93%)
hannesm
added a commit
to hannesm/opam-repository
that referenced
this pull request
Nov 30, 2020
CHANGES: * Dual IPv4 and IPv6 socket and direct stack support, now requires mirage-stack 2.2.0 and mirage-protocols 5.0.0 (mirage/mirage-tcpip#433 @hannesm) * The above change also unified arguments passed to connect functions which are API-breaking changes * IPv6 waits for timeout after sending neighbour advertisement (for duplicate address detection) * Remove Xen cross-compilation runes, with mirage-xen 6.0.0 they're provided by mirage-xen (mirage/mirage-tcpip#434 @hannesm) * Move to dune 2.7.0 (and bisect instrumentation if desired) (mirage/mirage-tcpip#436 @hannesm)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes #160 //cc @avsm