server: demote log level, make Dns_one.add_additional_glue more correct #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erver domain Previously, Domain_name.subdomain was used. This is brittle since zone cuts can be anywhere. Now, we check the Dns_trie (using lookup) that we're not authoritative for the nameserver name (or have a delegation).
…legations if a.example is delegated (a.example NS foo), and a record (glue) exists (a.example A 1.2.3.4), the Dns_trie.lookup returned it instead of a `Delegation error. This brings lookup and lookup_with_cname (which uses lookup_res) more into the same shape (lookup_aux >>= check_zone >>= lookup_in_map) Dns_trie.entries checked for SOA records, but zone cuts are at the presence of a NS record -- SOA is only present in the child zone (and thus only present if the very same NS is responsible for both parent and child).
|
best viewed commit by commit. includes test cases and bugfixes in the aftermath of #308 |
reynir
approved these changes
Apr 12, 2022
hannesm
added a commit
to hannesm/opam-repository
that referenced
this pull request
Jul 26, 2022
…er, dns-mirage, dns-client, dns-cli and dns-certify (6.3.0) CHANGES: * dns-server: demote log level for various messages (mirage/ocaml-dns#309 @hannesm) * dns-zone: add additional glue: only add if authoritative for nameserver domain (mirage/ocaml-dns#309 @hannesm) * BUGFIX: dns-trie: fix lookup when delegations are present, add tests (mirage/ocaml-dns#309 @hannesm) * ozone: be more explicit when showing errors (mirage/ocaml-dns#311 @psafont) * dns: avoid polymorphic comparison (mirage/ocaml-dns#314 @hannesm, reported by @RyanGibb) * FEATURE: dns: add LOC resource records (RFC 1876) (mirage/ocaml-dns#310 @RyanGibb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.