Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: demote log level, make Dns_one.add_additional_glue more correct #309

Merged
merged 5 commits into from
Apr 12, 2022
Merged

server: demote log level, make Dns_one.add_additional_glue more correct #309

merged 5 commits into from
Apr 12, 2022

Commits on Apr 12, 2022

  1. Dns_zone.add_additional_glue: only add if not authoritative for names… 

    …erver domain

Previously, Domain_name.subdomain was used. This is brittle since zone cuts
can be anywhere. Now, we check the Dns_trie (using lookup) that we're not
authoritative for the nameserver name (or have a delegation).
    @hannesm
    hannesm committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    aa4a15c View commit details
    Browse the repository at this point in the history

  2. Dns_server: demote log level to debug for various messages

    @hannesm
    hannesm committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    b819e63 View commit details
    Browse the repository at this point in the history

  3. dns_trie: fix lookup when delegations are present, fix entries for de… 

    …legations

if a.example is delegated (a.example NS foo), and a record (glue) exists
(a.example A 1.2.3.4), the Dns_trie.lookup returned it instead of a `Delegation
error. This brings lookup and lookup_with_cname (which uses lookup_res) more
into the same shape (lookup_aux >>= check_zone >>= lookup_in_map)

Dns_trie.entries checked for SOA records, but zone cuts are at the presence of
a NS record -- SOA is only present in the child zone (and thus only present if
the very same NS is responsible for both parent and child).
    @hannesm
    hannesm committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    1777a05 View commit details
    Browse the repository at this point in the history

  4. tests: for zones with glue, and zones with delegation

    @hannesm
    hannesm committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    1ae852e View commit details
    Browse the repository at this point in the history

  5. dns_zone:decode_zone comment about behaviour

    @hannesm
    hannesm committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    dc0a323 View commit details
    Browse the repository at this point in the history