resolver: do dnssec validation as an option #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannesm
force-pushed
the
resolver-dnssec-optional
branch
from
50b0c79
to
6d883f9
Compare
reynir
reviewed
Nov 25, 2022
reynir
approved these changes
Nov 29, 2022
| @@ -152,7 +152,7 @@ let resolve t ~rng ip_proto ts name typ = | |||
| *) | |||
| let rec go t types name = | |||
| Logs.debug (fun m -> m "go %a" Domain_name.pp name) ; | |||
| match find_nearest_ns rng ip_proto ts t (Domain_name.raw name) with | |||
| match find_nearest_ns rng ip_proto dnssec ts t (Domain_name.raw name) with | |||
| | `NeedAddress ns -> go t addresses ns | |||
| | `NeedDnskey (zone, ip) -> zone, zone, [`K (Rr_map.K Dnskey)], ip, t | |||
There was a problem hiding this comment.
`NeedDnskey should never be returned if dnssec is false. I don't think it's worth it to try encode it in the types, though.
|
Thanks! |
hannesm
added a commit
to hannesm/opam-repository
that referenced
this pull request
Dec 2, 2022
…er, dns-mirage, dns-client, dns-cli and dns-certify (6.4.1) CHANGES: * dns-client: adapt to happy eyeballs 0.4.0 (mirage/ocaml-dns#329 @reynir @hannesm) * dns-resolver: dnssec validation is optional via a labeled parameter ~dnssec passed to Dns_resolver.create (mirage/ocaml-dns#325 @hannesm) * upgrade to dune 2 (mirage/ocaml-dns#327 @reynir)
hannesm
added a commit
to hannesm/opam-repository
that referenced
this pull request
Dec 2, 2022
…er, dns-mirage, dns-client, dns-cli and dns-certify (6.4.1) CHANGES: * dns-client: adapt to happy eyeballs 0.4.0 (mirage/ocaml-dns#329 @reynir @hannesm) * dns-resolver: dnssec validation is optional via a labeled parameter ~dnssec passed to Dns_resolver.create (mirage/ocaml-dns#325 @hannesm) * upgrade to dune 2 (mirage/ocaml-dns#327 @reynir)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in #290 / 4276306 we added DNSSec support to the resolver. With this PR, the DNSSec validation is made optional (
Dns_resolver.createtakes a labelleddnssec:boolargument to switch it on or off for the lifetime of the resolver).