Upgrade to dune 2.0 #327
Merged
Upgrade to dune 2.0 #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ok, but why then |
|
Sure. I used 2.0.1 as 2.0.0 was unavailable. I'll change it. |
hannesm
reviewed
Nov 24, 2022
Co-authored-by: Hannes Mehnert <hannes@mehnert.org>
|
thanks |
hannesm
added a commit
to hannesm/opam-repository
that referenced
this pull request
Dec 2, 2022
…er, dns-mirage, dns-client, dns-cli and dns-certify (6.4.1) CHANGES: * dns-client: adapt to happy eyeballs 0.4.0 (mirage/ocaml-dns#329 @reynir @hannesm) * dns-resolver: dnssec validation is optional via a labeled parameter ~dnssec passed to Dns_resolver.create (mirage/ocaml-dns#325 @hannesm) * upgrade to dune 2 (mirage/ocaml-dns#327 @reynir)
hannesm
added a commit
to hannesm/opam-repository
that referenced
this pull request
Dec 2, 2022
…er, dns-mirage, dns-client, dns-cli and dns-certify (6.4.1) CHANGES: * dns-client: adapt to happy eyeballs 0.4.0 (mirage/ocaml-dns#329 @reynir @hannesm) * dns-resolver: dnssec validation is optional via a labeled parameter ~dnssec passed to Dns_resolver.create (mirage/ocaml-dns#325 @hannesm) * upgrade to dune 2 (mirage/ocaml-dns#327 @reynir)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that dune would attempt to compile ocaml-dns to javascript if its source was included as a subdirectory in happy-eyeballs. With help from people on the discord I had two solutions, and one of them was to upgrade to dune-lang 2.0.