forked from RIOT-OS/RIOT
-
Notifications
You must be signed in to change notification settings - Fork 0
Guidelines for Creating a Good Pull Request
Oleg Hahm edited this page Aug 25, 2015
·
1 revision
- The title and initial description of a pull request (PR) should describe its basic idea and what goal is intended to be achieved in a brief and comprehensible manner.
- Try your best to document how the provided code is intended to reach this goal. If the reviewer has difficulties to understand your approach, try to improve the documentation.
- Keep pull requests as small as possible. The smaller a PR, the more likely it gets reviewed in short time.
- Split your PR up into logical pieces. E.g. formatting changes or accompanying tests should go into separate commits.
- Support your reviewer! Try to react as quick as possible to your reviewer's comments - and if only by letting her/him know, that you have currently no time to incorporate her/his feedback. Also, let the reviewer know if you do not plan to continue to work on a certain PR. Furthermore, if your reviewer don't react for some days, remind him!
RIOT - The friendly Operating System for the Internet of Things
Homepage | [GitHub] (https://github.com/RIOT-OS/) | Developers Mailing List | Users Mailing List | Twitter @RIOT_OS
- Family: ARM
- Board: Airfy Beacon
- Board: Arduino Due
- Board: CC2538DK
- Board: HikoB Fox
- Board: IoT LAB M3
- Board: LimiFrog-v1
- Board: mbed_lpc1768
- Board: MSB-IoT
- Board: MSBA2
- Board: Nucleo-L1
- Board: Nucleo-F334
- Board: Nucleo-F303
- Board: Nucleo-F091
- Board: Mulle
- Board: OpenMote
- Board: PCA1000x (nRF51822 Development Kit)
- Board: Phytec phyWAVE-KW22
- Board: RFduino
- Board: Samr21 xpro
- Board: Spark Core
- Board: STM32F0discovery
- Board: STM32F3discovery
- Board: STM32F4discovery
- Board: UDOO
- Board: yunjia-nrf51822
- Family: ATmega
- Board: Arduino Mega2560
- Family: MSP430
- Board: MSB-430H
- Board: TelosB
- Board: WSN430
- Board: Zolertia Z1
- Board: eZ430-Chronos
- Family: native
- Board: native
- Family: x86
- Board: Intel Galileo