Fix tests from #1708 machine variable persistence #1709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
|
Perfect! Same thing I tweaked on local, so looks good. The other two were mine that I caught but hadn't been pushed before your PR. All looks good now! I have another PR, but didn't want to push until we get back to green. Thanks! |
avanwinkle
added a commit
to avanwinkle/mpf
that referenced
this pull request
Aug 31, 2023
…s-machine-vars-persist Fix tests from missionpinball#1708 machine variable persistence
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you @atummons for catching the test breakage in #1708 . When I saw the failures I was distracted by the sea of
'Event loop is closed.'failures and didn't catch that I had actually introduced new ones. This PR won't fix all the tests to pass green, but it does fix the tests in test_MachineVariables.py so we're at least not worse off than we were.