Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests from #1708 machine variable persistence #1709

Merged
merged 1 commit into from
Aug 31, 2023
Merged

Fix tests from #1708 machine variable persistence #1709

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions mpf/tests/test_MachineVariables.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,10 +70,12 @@ def testVarLoadAndRemove(self):
self.assertFalse(self.machine.variables.is_machine_var("expired_value"))
self.assertTrue(self.machine.variables.is_machine_var("not_expired_value"))
self.assertTrue(self.machine.variables.is_machine_var("player2_score"))
# should always persist
#self.assertTrue(self.machine.variables.machine_vars["player2_score"]["persist"])
# previously-persisted variables should continue to persist
self.assertTrue(self.machine.variables.machine_vars["player2_score"]["persist"])
# random variable does not persist
self.assertFalse(self.machine.variables.machine_vars["another_score"]["persist"])
self.machine.variables.set_machine_var("temporary_variable", 1000)
self.assertEqual(1000, self.machine.variables.get_machine_var("temporary_variable"))
self.assertFalse(self.machine.variables.machine_vars["temporary_variable"]["persist"])
# configured to persist
self.assertTrue(self.machine.variables.machine_vars["test1"]["persist"])
self.assertTrue(self.machine.variables.machine_vars["test2"]["persist"])
Expand Down Expand Up @@ -101,6 +103,8 @@ def testVarLoadAndRemove(self):

self.machine.variables.machine_var_data_manager._trigger_save.assert_called_with()
self.assertEqual({
'another_score': {'value': 123, 'expire': None, 'expire_secs': None},
"not_expired_value": {'value': 24, 'expire': None, 'expire_secs': None},
'master_volume': {'value': 0.5, 'expire': None, 'expire_secs': None},
'test1': {'value': 42, 'expire': None, 'expire_secs': None},
'test2': {'value': '5', 'expire': None, 'expire_secs': None},
Expand Down
Loading