Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client): cat ears are clipped in MkReactionsViewer #10445

Merged
merged 4 commits into from
Apr 14, 2023

Conversation

acid-chicken
Copy link
Member

What

リアクション一覧で猫耳が(ほぼ)見切れないようにする

Screenshot 2023-03-31 at 17-17-37 しゅいろ (@syuilo)

Why

猫耳が見切れる

Screenshot 2023-03-31 at 17-17-27 しゅいろ (@syuilo)

Additional info (optional)

ユーザー間のマージンを 3px から 4px に変更しています

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Mar 31, 2023
@github-actions github-actions bot requested a review from syuilo March 31, 2023 08:24
@codecov
Copy link

codecov bot commented Mar 31, 2023

Codecov Report

Merging #10445 (9c2fec4) into develop (7d3b798) will increase coverage by 2.27%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop   #10445      +/-   ##
===========================================
+ Coverage    76.06%   78.34%   +2.27%     
===========================================
  Files          896      164     -732     
  Lines        88499    20450   -68049     
  Branches      6246      363    -5883     
===========================================
- Hits         67318    16021   -51297     
+ Misses       21181     4429   -16752     
Impacted Files Coverage Δ
...ntend/src/components/MkReactionsViewer.details.vue 100.00% <100.00%> (ø)

... and 732 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tamaina
Copy link
Contributor

tamaina commented Apr 14, 2023

なんかborderが2本表示される

@tamaina
Copy link
Contributor

tamaina commented Apr 14, 2023

多分なおった

@tamaina tamaina changed the title fix: cat ears are clipped in MkReactionsViewer fix(client): cat ears are clipped in MkReactionsViewer Apr 14, 2023
@tamaina tamaina merged commit c47a0f7 into develop Apr 14, 2023
@tamaina tamaina deleted the acid-chicken-patch-2 branch April 14, 2023 07:00
@tamaina
Copy link
Contributor

tamaina commented Apr 14, 2023

🙏🙏🙏🙏

na2na-p pushed a commit to na2na-p/misskey that referenced this pull request May 10, 2023
…0445)

* fix: cat ears are clipped in MkReactionsViewer

* fix: missing padding

* fix border

---------

Co-authored-by: tamaina <tamaina@hotmail.co.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants