Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): アイコンデコレーションが見切れる問題を修正 #12239

Merged

Conversation

zyoshoka
Copy link
Contributor

@zyoshoka zyoshoka commented Nov 4, 2023

What

アイコンデコレーションが以下の部分で見切れてしまう問題を修正しました。

  • ナビゲーションバー
  • ノート内のリアクション一覧
  • ノートプレビュー

Before

before-navbar-wide before-navbar-narrow before-reactions-viewer before-note-preview

After

after-navbar-wide after-navbar-narrow after-reactions-viewer after-note-preview

Why

Fix: #12198

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Nov 4, 2023
Copy link

codecov bot commented Nov 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f635a48) 78.96% compared to head (9f2e6d4) 78.84%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12239      +/-   ##
===========================================
- Coverage    78.96%   78.84%   -0.12%     
===========================================
  Files          944      945       +1     
  Lines       101881   101951      +70     
  Branches      8272     8236      -36     
===========================================
- Hits         80447    80386      -61     
- Misses       21434    21565     +131     
Files Coverage Δ
packages/frontend/src/components/MkPostForm.vue 100.00% <100.00%> (ø)
...ntend/src/components/MkReactionsViewer.details.vue 100.00% <100.00%> (ø)

... and 22 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Nov 4, 2023

このPRによるapi.jsonの差分

差分はこちら
--- base
+++ head
@@ -61391,12 +61391,6 @@
             "optional": false,
             "nullable": true,
             "format": "date-time"
-          },
-          "latestRequestReceivedAt": {
-            "type": "string",
-            "optional": false,
-            "nullable": true,
-            "format": "date-time"
           }
         },
         "required": [
@@ -61421,8 +61415,7 @@
           "faviconUrl",
           "themeColor",
           "isSilenced",
-          "infoUpdatedAt",
-          "latestRequestReceivedAt"
+          "infoUpdatedAt"
         ]
       },
       "GalleryPost": {

Get diff files from Workflow Page

@syuilo
Copy link
Member

syuilo commented Nov 4, 2023

これやるとナビゲーションバーが無駄にスクロール発生するようにならない?

@syuilo
Copy link
Member

syuilo commented Nov 4, 2023

あーこのコミット 5fb6847 でナビゲーションバーの幅を微調整したことにより奇跡的にデコレーションが収まるようになってスクロール発生しなくなったっぽいけど、あくまで現状奇跡的に一致してるだけだから今後何かしらの変更によってスクロール発生するようになる可能性は高い

@syuilo
Copy link
Member

syuilo commented Nov 4, 2023

だから overflow: clip を消す以外の方法で対応する必要がありそう

@zyoshoka
Copy link
Contributor Author

zyoshoka commented Nov 4, 2023

margin か padding で微調整してみます

@zyoshoka
Copy link
Contributor Author

zyoshoka commented Nov 4, 2023

上下 20px の余白にしました(ノートボタンとアカウントの間が 4px だけ広がります)
Screenshot 2023-11-04 at 19 34 06

@zyoshoka zyoshoka changed the title fix(frontend): アイコンデコレーションがナビゲーションバーでクリップされないように fix(frontend): アイコンデコレーションがナビゲーションバー/ノートプレビューでクリップされないように Nov 10, 2023
@zyoshoka
Copy link
Contributor Author

ノートプレビューについても対応しました(他にあるかしら)

@zyoshoka zyoshoka marked this pull request as draft November 11, 2023 03:15
@zyoshoka
Copy link
Contributor Author

リアクション一覧で途切れていた問題を修正しました
Related to #10445

@zyoshoka zyoshoka changed the title fix(frontend): アイコンデコレーションがナビゲーションバー/ノートプレビューでクリップされないように fix(frontend): アイコンデコレーションが見切れる問題を修正 Nov 11, 2023
@zyoshoka
Copy link
Contributor Author

他にはなさそう

@zyoshoka zyoshoka marked this pull request as ready for review November 11, 2023 06:24
@syuilo syuilo merged commit 0dd3cac into misskey-dev:develop Nov 11, 2023
17 of 18 checks passed
@syuilo
Copy link
Member

syuilo commented Nov 11, 2023

🙏

@zyoshoka zyoshoka deleted the disable-clipping-of-decoration-in-navbar branch May 15, 2024 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Profile decoration, wrong margin inside "profile button", navigation menu
2 participants