Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): use-tooltip の呼び出し元の UI が無くなったら自動的に削除されるようにする #11949

Merged
merged 3 commits into from
Oct 3, 2023

Conversation

YAVIIGI
Copy link
Contributor

@YAVIIGI YAVIIGI commented Oct 1, 2023

What

#11931 にて提出した use-tooltip により表示される UI が特定の条件下で消えなくなる不具合を解消します。
具体的には、user-preview 側で行っている 1000ms で呼び出し元の UI が存在しているか否かをチェックする処理を use-tooltip 側でも適用させ、呼び出し元の UI が無くなったら use-tooltip 側の UI も自動的に削除されるようにします。

20231002.mp4

Why

misskey にて何度か目にする現象であり、修正し品質向上につなげるため

Additional info (optional)

  1. ReactionsViewer にフォーカスを当てて ReactionsViewer.Detail を表示する
  2. ReactionsViewer.Detail が表示されている間に前に戻る/次に移動などの操作でページ遷移する
  3. ReactionsViewer.Detail が左上に移動する

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Oct 1, 2023
@YAVIIGI YAVIIGI force-pushed the cannot-hide-reaction-detail branch from 7e85cdc to 22f6559 Compare October 1, 2023 16:27
@codecov
Copy link

codecov bot commented Oct 1, 2023

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (6840434) 79.00% compared to head (22f6559) 78.94%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #11949      +/-   ##
===========================================
- Coverage    79.00%   78.94%   -0.07%     
===========================================
  Files          928      930       +2     
  Lines        99089    99272     +183     
  Branches      7913     7882      -31     
===========================================
+ Hits         78289    78374      +85     
- Misses       20800    20898      +98     
Files Coverage Δ
packages/frontend/src/scripts/use-tooltip.ts 7.61% <0.00%> (-1.18%) ⬇️

... and 20 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo syuilo merged commit e00fdc2 into misskey-dev:develop Oct 3, 2023
15 checks passed
@syuilo
Copy link
Member

syuilo commented Oct 3, 2023

👍👍

kanarikanaru pushed a commit to kanarikanaru/misskey that referenced this pull request Oct 12, 2023
typeling1578 pushed a commit to typeling1578/misskey that referenced this pull request Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants