fix(frontend): use-tooltip の呼び出し元の UI が無くなったら自動的に削除されるようにする #11949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YAVIIGI
force-pushed
the
cannot-hide-reaction-detail
branch
from
7e85cdc
to
22f6559
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #11949 +/- ##
===========================================
- Coverage 79.00% 78.94% -0.07%
===========================================
Files 928 930 +2
Lines 99089 99272 +183
Branches 7913 7882 -31
===========================================
+ Hits 78289 78374 +85
- Misses 20800 20898 +98
☔ View full report in Codecov by Sentry. |
|
👍👍 |
kanarikanaru
pushed a commit
to kanarikanaru/misskey
that referenced
this pull request
Oct 12, 2023
…dev#11949) * Update use-tooltip.ts * Update CHANGELOG.md
typeling1578
pushed a commit
to typeling1578/misskey
that referenced
this pull request
Oct 15, 2023
…dev#11949) * Update use-tooltip.ts * Update CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
#11931 にて提出した use-tooltip により表示される UI が特定の条件下で消えなくなる不具合を解消します。
具体的には、user-preview 側で行っている 1000ms で呼び出し元の UI が存在しているか否かをチェックする処理を use-tooltip 側でも適用させ、呼び出し元の UI が無くなったら use-tooltip 側の UI も自動的に削除されるようにします。
20231002.mp4
Why
misskey にて何度か目にする現象であり、修正し品質向上につなげるため
Additional info (optional)
Checklist