Hard mute #12376
Merged
Hard mute #12376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
packages/frontend
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #12376 +/- ##
========================================
Coverage 78.80% 78.80%
========================================
Files 948 948
Lines 102884 102933 +49
Branches 8285 8289 +4
========================================
+ Hits 81077 81119 +42
- Misses 21807 21814 +7 ☔ View full report in Codecov by Sentry. |
|
このPRによるapi.jsonの差分 差分はこちら--- base
+++ head
@@ -39907,7 +39907,36 @@
"nullable": true
},
"mutedWords": {
- "type": "array"
+ "type": "array",
+ "items": {
+ "oneOf": [
+ {
+ "type": "array",
+ "items": {
+ "type": "string"
+ }
+ },
+ {
+ "type": "string"
+ }
+ ]
+ }
+ },
+ "hardMutedWords": {
+ "type": "array",
+ "items": {
+ "oneOf": [
+ {
+ "type": "array",
+ "items": {
+ "type": "string"
+ }
+ },
+ {
+ "type": "string"
+ }
+ ]
+ }
},
"mutedInstances": {
"type": "array",
@@ -63402,6 +63431,18 @@
}
}
},
+ "hardMutedWords": {
+ "type": "array",
+ "nullable": false,
+ "items": {
+ "type": "array",
+ "nullable": false,
+ "items": {
+ "type": "string",
+ "nullable": false
+ }
+ }
+ },
"mutedInstances": {
"type": "array",
"nullable": true,
@@ -63615,6 +63656,7 @@
"hasPendingReceivedFollowRequest",
"unreadNotificationsCount",
"mutedWords",
+ "hardMutedWords",
"mutedInstances",
"notificationRecieveConfig",
"emailNotificationTypes", |
|
API reportはbaseをfetchマージしてないからですがbaseはbaseで別の変更が入っててAPI report落ちてるのでそれは別PRなげます。それが入ったらbaseをmergeします |
anatawa12
commented
Nov 21, 2023
|
私の思った動作はしてるので私としてはOKだと思ってます |
|
👍👍 |
u1-liquid
reviewed
Nov 23, 2023
| @@ -234,28 +240,42 @@ export default class extends Endpoint<typeof meta, typeof paramDef> { // eslint- | |||
| if (ps.location !== undefined) profileUpdates.location = ps.location; | |||
| if (ps.birthday !== undefined) profileUpdates.birthday = ps.birthday; | |||
| if (ps.ffVisibility !== undefined) profileUpdates.ffVisibility = ps.ffVisibility; | |||
| if (ps.mutedWords !== undefined) { | |||
|
|
|||
| function checkMuteWordCount(mutedWords: (string[] | string)[], limit: number) { | |||
| // TODO: ちゃんと数える | |||
| const length = JSON.stringify(ps.mutedWords).length; | |||
There was a problem hiding this comment.
ここps.mutedWordsではなくmutedWordsを参照しなければならない気がします
5 tasks
nafu-at
added a commit
to TeamNijimiss/nijimiss_legacy
that referenced
this pull request
Nov 24, 2023
This reverts commit 864827f.
u1-liquid
added a commit
to u1-liquid/misskey
that referenced
this pull request
Nov 25, 2023
This reverts commit 864827f partially. 型定義に関する実装はそのままに 一部型定義に合わない実装の修正
anatawa12
added a commit
to anatawa12/misskey
that referenced
this pull request
Nov 25, 2023
* feat(backend,misskey-js): hard mute storage in backend * fix(backend,misskey-js): mute word record type * chore(frontend): generalize XWordMute * feat(frontend): configure hard mute * feat(frontend): hard mute notes on the timelines * lint(backend,frontend): fix lint failure * chore(misskey-js): update api.md * fix(backend): test failure * chore(frontend): check word mute for reply * chore: limit hard mute count
This was referenced Nov 26, 2023
camilla-ett
pushed a commit
to kaseiski/misskey
that referenced
this pull request
Jan 2, 2024
* feat(backend,misskey-js): hard mute storage in backend * fix(backend,misskey-js): mute word record type * chore(frontend): generalize XWordMute * feat(frontend): configure hard mute * feat(frontend): hard mute notes on the timelines * lint(backend,frontend): fix lint failure * chore(misskey-js): update api.md * fix(backend): test failure * chore(frontend): check word mute for reply * chore: limit hard mute count
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fix #12375
とりあえず最低限動いたのでPullReqにします多分完成Why
Additional info (optional)
Checklist