Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: word mute did not apply to quote notes #12468

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

qwreey
Copy link
Contributor

@qwreey qwreey commented Nov 26, 2023

What

image
Apply word mute on quoted note like replied note to ensure consistency

Why

Unlike replied note, word mute is not affect on quoted note
image

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Nov 26, 2023
Copy link

codecov bot commented Nov 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ebdb443) 79.67% compared to head (4dc5774) 78.90%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12468      +/-   ##
===========================================
- Coverage    79.67%   78.90%   -0.77%     
===========================================
  Files          959      775     -184     
  Lines       108407    80156   -28251     
  Branches      8348     7840     -508     
===========================================
- Hits         86372    63248   -23124     
+ Misses       22035    16908    -5127     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anatawa12
Copy link
Member

#12376 で違う形で(引用ごとsoft muteされる)効くようにした記憶があります

@qwreey qwreey closed this Nov 26, 2023
@qwreey qwreey reopened this Nov 26, 2023
@qwreey
Copy link
Contributor Author

qwreey commented Nov 26, 2023

# 12376 에서 다른 형태로 (인용 당 soft mute되는) 효과를 낸 기억이 있습니다.

It's slightly different. The purpose of this commit is to ensure that the behavior of quote and reply is the same.
At your pull request, Main notes are well hidden, However, when the main note is opened, the subnotes are not hidden. unlike reply
image

image

@qwreey
Copy link
Contributor Author

qwreey commented Nov 26, 2023

image
image
When open note, You can see that the purposes are different. (maybe...?)

@samunohito
Copy link
Member

@syuilo
ちょっと取り込み是非を伺いたく…

以下があったとして、

  • ワードミュート対象の単語を含んだノート(以下、ノートA)
  • ワードミュート対象の単語を含まないが、ノートAを引用しているノート(以下、ノートB)

ノートBの中に表示されているノートAには、ワードミュートによる非表示機能が無いのでそれを追加しようという意図のようです。

@syuilo
Copy link
Member

syuilo commented Dec 10, 2023

LGTM

@samunohito
Copy link
Member

@qwreey
There seems to be no problem with the policy. However, there is a discrepancy in the source code, so I would like it to be resolved.

@qwreey
Copy link
Contributor Author

qwreey commented Dec 11, 2023

@qwreey There seems to be no problem with the policy. However, there is a discrepancy in the source code, so I would like it to be resolved.

@samunohito Source code rebased. now, have no conflict! (I moved all commit to forward, for making git log clear)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants