This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
Use cross-platform dependencies in place of golang.org/x/crypto/ssh/terminal #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Functions in golang.org/x/crypto/ssh/terminal (in particular terminal.IsTerminal(int) and ReadPassword(string) on the Terminal struct which are used in the CLI user interface) are coded directly against system calls, and do not compile on Solaris-derived Unix systems - notably SmartOS. This commit replaces calls to terminal.IsTerminal with the go-isatty package, which is cross platform, and calls to ReadPassword with the go-speakeasy package in order to be compatible with SmartOS.
5 tasks
|
LGTM |
|
Thanks! |
mitchellh
added a commit
that referenced
this pull request
Jan 5, 2016
Use cross-platform dependencies in place of golang.org/x/crypto/ssh/terminal
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functions in
golang.org/x/crypto/ssh/terminal(in particularterminal.IsTerminal(int)andReadPassword(string)on theTerminalstruct which are used in the CLI user interface) are coded directly against system calls, and do not compile on Solaris-derived Unix systems - notably SmartOS.This commit replaces calls to terminal.IsTerminal with the go-isatty package, which is cross platform, and calls to ReadPassword with the go-speakeasy package in order to be compatible with SmartOS.
This does not affect the public API of the CLI package.