Modernize Addon Infrastructure #61
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexlafroscia
force-pushed
the
addon-modernization
branch
from
4fd4666 to
6ddbf4b
Compare
BREAKING CHANGE: No longer running tests against versions below Ember 3.12
BREAKING CHANGE: Error about missing component is no longer swallowed in Production
alexlafroscia
force-pushed
the
addon-modernization
branch
from
6ddbf4b to
ebba2e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am being bitten by #59 and intend to fix that bug. However, I ran into the fact that a lot of the patterns followed in the addon were pretty dated and decided to shave that yak first.
This gets the addon following the patterns that would be used if the addon were to be generated today using Ember 3.19.
I took the liberty of adding Prettier here, too, which is not yet part of the default Ember configuration but will be soon. This just made it easier to make sure that all of the files followed a consistent formatting pattern.
I would treat this as a breaking change, as the tests now only go back to Ember 3.12. I can add back the others to be tested instead, but I think it would be nice to bump the minimum supported version so that the addon logic itself can be modernized where possible.