Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Take advantage of some clap features #521

Merged
merged 28 commits into from
Aug 2, 2024
Merged

Take advantage of some clap features #521

merged 28 commits into from
Aug 2, 2024

Conversation

max-sixty
Copy link
Collaborator

@max-sixty max-sixty commented Jul 5, 2024 •
edited
Loading

Stacks on #518, so that needs to merge first. I put this as a separate PR to avoid delaying merging that.

For example, this reorganizes the --help options, with a separate section for arguments that are passed to the test runner:

....
      --test-runner <TEST_RUNNER>
          Picks the test runner [default: auto] [possible values: auto, cargo-test, nextest]
  -h, --help
          Print help

Test Runner Options:
      --lib
          Test only this package's library unit tests
      --bin <BIN>
          Test only the specified binary
...

max-sixty added 3 commits July 3, 2024 19:01
@max-sixty
[draft] Upgrade structopt to clap
0e84072 
Still need to finish this off, one test fails.

`structopt` was build on clap 2, and then its features were integrated into clap 3. So it's not actually a heavier dependency. May have to check on MSRV issues.

Once we merge this, we only have one version of `syn`, which reduces our dependency size significantly.
@max-sixty
take advantage of some clap features to simplify the code
c2c1f88
@max-sixty
Take advantage of some clap features
32a427f 
Stacks on mitsuhiko#518
max-sixty added a commit to max-sixty/insta that referenced this pull request Jul 31, 2024
@max-sixty
Fix test_runner in config
f3cbd5b 
This was previously ignored.

Stacks on mitsuhiko#521 to avoid conflicts; merge that first
@max-sixty max-sixty mentioned this pull request Jul 31, 2024
Merged
@mitsuhiko
Copy link
Owner

This has some conflicts how that #518 landed.

@max-sixty
Copy link
Collaborator Author

conflicts resolved

@max-sixty max-sixty requested a review from mitsuhiko August 1, 2024 22:54
@mitsuhiko mitsuhiko merged commit 9c14caf into mitsuhiko:master Aug 2, 2024
15 checks passed
@max-sixty max-sixty deleted the clap-more branch August 2, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitsuhiko mitsuhiko Awaiting requested review from mitsuhiko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@max-sixty @mitsuhiko