-
-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix test_runner
in config
#544
Merged
mitsuhiko
merged 32 commits into
mitsuhiko:master
from
max-sixty:tool-config-test-runner
Aug 2, 2024
Merged
Fix test_runner
in config
#544
mitsuhiko
merged 32 commits into
mitsuhiko:master
from
max-sixty:tool-config-test-runner
Aug 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still need to finish this off, one test fails. `structopt` was build on clap 2, and then its features were integrated into clap 3. So it's not actually a heavier dependency. May have to check on MSRV issues. Once we merge this, we only have one version of `syn`, which reduces our dependency size significantly.
Need to upgrade structopt and then we'll reduce the compile time.
This was previously ignored. Stacks on mitsuhiko#521 to avoid conflicts; merge that first
max-sixty
added a commit
to max-sixty/insta
that referenced
this pull request
Jul 31, 2024
This allows a project to default to `nextest` in its insta config, while falling back to `cargo test` when that isn't available. Stacks on mitsuhiko#544 Needs an integration test, will add when mitsuhiko#537 merges
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was previously ignored.
Stacks on #521 to avoid conflicts; merge that first