fix: use conventionalcommits in semantic-release #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
skeggse
force-pushed
the
eli/fix-conventionalcommits
branch
from
6b980f8
to
073cf8f
Compare
skeggse
commented
Nov 1, 2019
skeggse
commented
Nov 1, 2019
Comment on lines
1
to
6
| module.exports = [ | ||
| { | ||
| type: 'improvement', | ||
| release: 'patch', | ||
| }, | ||
| ]; |
There was a problem hiding this comment.
The conventionalcommits spec has two commit types in addition to the ones in the angular preset: chore and improvement. The chore type shouldn't trigger a release.
There are other commit types that aren't included in the default release rules, but none of those should trigger a release either.
skeggse
force-pushed
the
eli/fix-conventionalcommits
branch
from
d52c42e
to
bfb6e48
Compare
Fix an assumption around how semantic-release would interpret commit types by using the conventionalcommits preset.
skeggse
force-pushed
the
eli/fix-conventionalcommits
branch
from
bfb6e48
to
6d86eb0
Compare
An improvement that's anything more than a bugfix cannot merely be a patch release, per the semver spec.
skeggse
force-pushed
the
eli/fix-conventionalcommits
branch
from
6d86eb0
to
63fb94b
Compare
|
Forgive the force-pushes - I was having some personal problems. |
shils
approved these changes
Nov 2, 2019
|
🎉 This PR is included in version 1.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an assumption around how
semantic-releasewould interpret commit types by using theconventionalcommitspreset.Upstreamed
improvementtype release rule support: semantic-release/commit-analyzer#149.