Merge pull request #13005 from Ashnidh/expandSamplerTooltip

Added tooltip for expand/collapse samplers button.
mixxxdj · Mar 27, 2024 · c80f802 · c80f802
2 parents 8326ecd + b51e46a
commit c80f802
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 3 deletions.
diff --git a/res/skins/Deere/sampler_row.xml b/res/skins/Deere/sampler_row.xml
@@ -45,6 +45,7 @@
 
           <Template src="skin:hide_show_button.xml">
             <SetVariable name="object_name">SamplerRowExpandButton</SetVariable>
+            <SetVariable name="TooltipId">expand_samplers</SetVariable>
             <SetVariable name="control">[Skin],sampler_row_<Variable name="row"/>_expanded</SetVariable>
           </Template>
 

diff --git a/res/skins/LateNight/samplers/sampler_expand_button.xml b/res/skins/LateNight/samplers/sampler_expand_button.xml
@@ -9,7 +9,7 @@
         <Layout>stacked</Layout>
         <Children>
           <PushButton>
-            <TooltipId>show_samplers</TooltipId>
+            <TooltipId>expand_samplers</TooltipId>
             <ObjectName>SamplerExpandOverlay</ObjectName>
             <Size>16f,36me</Size>
             <NumberStates>2</NumberStates>

diff --git a/res/skins/Shade/samplerrow.xml b/res/skins/Shade/samplerrow.xml
@@ -31,7 +31,7 @@
 						<Layout>horizontal</Layout>
 						<Children>
 							<PushButton>
-								<TooltipId>show_samplers</TooltipId>
+								<TooltipId>expand_samplers</TooltipId>
 								<NumberStates>2</NumberStates>
 								<State>
 									<Number>0</Number>
@@ -158,7 +158,7 @@
 						<BackPath>style/style_bg_sampler_right.png</BackPath>
 						<Children>
 							<PushButton>
-								<TooltipId>show_samplers</TooltipId>
+								<TooltipId>expand_samplers</TooltipId>
 								<NumberStates>2</NumberStates>
 								<State>
 									<Number>0</Number>

diff --git a/res/skins/Tango/mic_aux_sampler/sampler_row.xml b/res/skins/Tango/mic_aux_sampler/sampler_row.xml
@@ -47,6 +47,7 @@ Variables:
               <WidgetGroup><Size>1min,3f</Size></WidgetGroup>
               <Template src="skins:Tango/controls/button_2state_persist.xml">
                 <SetVariable name="ObjectName">SamplersMiniMaxi</SetVariable>
+                <SetVariable name="TooltipId">expand_samplers</SetVariable>
                 <SetVariable name="Size">20f,30me</SetVariable>
                 <SetVariable name="ConfigKey">[Skin],sampler_row_<Variable name="row"/>_expanded</SetVariable>
               </Template>

diff --git a/src/skin/legacy/tooltips.cpp b/src/skin/legacy/tooltips.cpp
@@ -664,6 +664,10 @@ void Tooltips::addStandardTooltips() {
             << tr("Record Mix")
             << tr("Toggle mix recording.");
 
+    add("expand_samplers")
+            << tr("Expand/Collapse Samplers")
+            << tr("Toggle expanded samplers view.");
+
     // Status displays and toggle buttons
     add("recording_duration")
             << tr("Recording Duration")