Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tooltip for expand/collapse samplers button. #13005

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

Ashnidh
Copy link
Contributor

@Ashnidh Ashnidh commented Mar 27, 2024

Resolves #12998.
I added tooltip for the expand/collapse samplers buttons.
The tooltip used is as follows:

Expand/Collapse Samplers
Toggle expanded samplers view.

I have tested the same for all the skins available.
Kindly review.

Here are the screenshots taken in different skins -
Screenshot from 2024-03-27 13-07-03
Screenshot from 2024-03-27 13-08-25

Screenshot from 2024-03-27 13-08-51
Screenshot from 2024-03-27 13-09-18

@github-actions github-actions bot added the skins label Mar 27, 2024
@ronso0
Copy link
Member

ronso0 commented Mar 27, 2024

Thank you for this PR.
Please sign the Mixxx Contributor Agreement and comment here when you have done so. It gives us permission to distribute your contribution under the GPL v2 or later license and the Apple Mac App Store. It is also helpful for us to have contact information for contributors in case we may need it in the future.

Please comment here when done.

@Ashnidh
Copy link
Contributor Author

Ashnidh commented Mar 27, 2024

Thank you sir. I have signed the agreement.

@ronso0
Copy link
Member

ronso0 commented Mar 27, 2024

Thanks.
LGTM

Congratulations for your first merged PR!
(waiting for CI)

@ronso0 ronso0 merged commit c80f802 into mixxxdj:main Mar 27, 2024
13 checks passed
@ronso0 ronso0 added the tooltip label Mar 27, 2024
@daschuer
Copy link
Member

Hi @Ashnidh, I like to add your to the contributor list in the Mixxx about box. Should I write your full name or just Ashnidh?

@Ashnidh
Copy link
Contributor Author

Ashnidh commented Apr 14, 2024

Hello @daschuer.
You many mention my full name - Ashnidh Khandelwal
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong tooltip for samplers expand button
3 participants