Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AutoDJ: Crossfader jumps into Center after last transition #10683

Closed
mixxxbot opened this issue Aug 23, 2022 · 7 comments
Closed

AutoDJ: Crossfader jumps into Center after last transition #10683

mixxxbot opened this issue Aug 23, 2022 · 7 comments
Milestone

Comments

@mixxxbot
Copy link
Collaborator

Reported by: andysmixxx
Date: 2022-03-17T12:19:50Z
Status: Fix Released
Importance: High
Launchpad Issue: lp1965298
Tags: autodj
Attachments: transition.jpg


In AutoDJ the Crossfader jumps into the centerposition directly after the last(!) transition ends.
That means if you record the AutoDJ set you can see and her an -6db drop at the beginning of the last track. You can "repair" it in the post, but it would be nice if the Crossfader stays in the left or right postion depending where the last track is played.

BR
Andy

@mixxxbot
Copy link
Collaborator Author

Commented by: andysmixxx
Date: 2022-03-17T12:24:31Z
Attachments: transition.jpg


Picture of the Bug

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2022-03-17T14:22:44Z


This is an odd bug I am supposed no one else found it.
This happen due to the constant power setting of the crossfader.

The jump back to center has been introduced for controllers with no crossfader.
It works flawlessly for the Mixing setting.

We may disable the jump back in case of constant power setting.

What do others think?

@mixxxbot
Copy link
Collaborator Author

Commented by: ronso0
Date: 2022-03-17T15:18:14Z


I suppose moving the xfader to center is supposed to facilitate 'something' for 'some user group'?

IMO we should remove such magic and leave the crossfader whereit is, no matter if it's the last queued song or if AutoDJ is stopped manually.

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2022-03-17T18:49:35Z


The feature has been introduced here:
#313

For constant power-crossfader users this is has introduced a bug. But no one has complained during the last 8 years ... so it seems to work well for the majority :-/

I don't mind to remove it. It is a single line only.

However doing it in a stable release effects the workflow of the majority. Coupling it with the constant power setting, solely fixes the bug.

What do you think?

@mixxxbot
Copy link
Collaborator Author

Commented by: ronso0
Date: 2022-03-17T23:21:21Z


You're right about not introducing changes for unaffected users in a stable release, that should be avoided if possible. However, I'd appreciate a consistent fix. Making the crossfader behaviour depend on the selected xfader mode is confusing IMO.

Also, tbh I don't agree with the rationale for mixxxdj/mixxx#5222 in the first place. Using automation when turning AutoDJ OFF to work around forgetting to check a central, obvious DJ control is not appropriate IMO. If that was about some rather inaccessible effect toggle or something, okay, but it's the crossfader :| And it's even more obvious since it's been moved by AutoDJ all the time.

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2022-07-03T19:58:48Z


#4714

@mixxxbot
Copy link
Collaborator Author

Issue closed with status Fix Released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant