reset xfader to 0 when disabling autodj #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems ok to me, I'm just trying to think if there's any situation where this would be a problem. The crossfader is already not going to match the midi controller since it's been controlled by the autoDJ, so that's not an issue... It's not like someone's going to have a track playing in some other deck.... yup LGTM. |
ywwg
added a commit
that referenced
this pull request
Aug 16, 2014
reset xfader to 0 when disabling autodj
|
If someone had a waiting track to make a smooth transition while stopping autodj it would normally be in the headphones, not the master, so the brutal xfader change wouldn't have any impact on the result. I don't see any other situation. Anyway, thanks. |
m0dB
pushed a commit
to m0dB/mixxx
that referenced
this pull request
Jan 21, 2024
Delete trailing whitespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes (probably often), when I disable autodj to play with my music, I don't understand why I'm unable to hear one of the playing tracks, it always because autodj set the crossfader to one track and I forgot to put it back at the center.
This would avoid these frustrations! :)