add AutoDJ xfader recenter option (default off)

[ronso0]

adopting #13156 but cleaning up the "buffer" settings before
(that dlg wrote some "...Buff" settings to config for storing temp pending settings...)

Fixes #11571

TODO:

• add a note how re-centering may affect main volume (see AutoDJ: Crossfader jumps into Center after last transition #10683 and Don't reset xfader when auto DJ is disabled #4714)

[Eve00000]

Hi Ronso,
I was almost ready to upload my adapted version, but you already did the changes. You cleaned up the whole routine. Thank you for the work and congratulations it surely will be better then mine .
I will learn by comparing your version with what I did.

If it's possible I just want to add the lines in the ui with some explanation (tooltip),
I don't know how to add that in the pr so I'll write it here.

<property name="toolTip">
<string>When checked, the Crossfader will be set to the default center position after disabling the Auto DJ.
This can be handy when you're working with an external mixer and don't need to see the Mixxx-mixer and crossfader 
(mixer and/or crossfader disabled in the skin-options).

Please mind that the crossfader adds some volume to the pointed playing deck in the main output, 
so centering the crossfader will cause a volumedrop in the main output.
</string>
</property>

greetings

[ronso0]

Thanks for your proposal, I already added the hint as static label (no as tooltip which may not be discovered).

Ready for review!

[Swiftb0y]

couple comments, looks pretty good so far. I can't really review the ui file though

[Swiftb0y]

stray comment

Suggested change

	// if (m_pConfig->getValue<bool>(ConfigKey(kAutoDJGroup,
	if (m_pConfig->getValue<bool>(ConfigKey(kConfigKey,
	QStringLiteral("center_xfader_when_disabling")))) {
	if (m_pConfig->getValue<bool>(ConfigKey(kConfigKey,
	QStringLiteral("center_xfader_when_disabling")))) {

[ronso0]

whoopsy

[Swiftb0y]

no need to implicitly depend on the display format or construct the time in an an unnecessarily slow fashion.

Suggested change

	RequeueIgnoreTimeEdit->setTime(QTime::fromString(
	"23:59", RequeueIgnoreTimeEdit->displayFormat()));
	RequeueIgnoreTimeEdit->setTime(QTime(23, 59));

[Swiftb0y]

would it make more sense to set use crossfader_set_default here?

[ronso0]

Sure, butfor that we'd need another control, either via ControlObject::get() or another member.
I'd prefer to stick to the crossfader CO.

[Swiftb0y]

fair. I just thought the _set_default was more expressive.

[Swiftb0y]

I'd be nice if these defaults were constexpr statics. Currently they're duplicated a bunch of times.

[ronso0]

Jep, moving all repeatedly used pref ConfigKeys (preferences, and respective engine units) to other files.
I have some changes stashed already, but I prefer to do that in a separate PR.

[Swiftb0y]

LGTM. feel free to squash and force push

[Swiftb0y]

Sorry, forgot about this.