Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Effect Parameters are not shown when their Manifest has been changed #10834

Closed
Swiftb0y opened this issue Aug 29, 2022 · 0 comments · Fixed by #10837
Closed

Effect Parameters are not shown when their Manifest has been changed #10834

Swiftb0y opened this issue Aug 29, 2022 · 0 comments · Fixed by #10837
Labels
effects
Milestone
2.4.0

Comments

@Swiftb0y
Copy link
Member

This is due to the fact that only the default preset is loaded from the file and not compared whether it still matches the original effect manifest. More info:
https://mixxx.zulipchat.com/#narrow/stream/247620-development-help/topic/EffectPresetManager.20Default.20presets
@Swiftb0y Swiftb0y added this to the 2.4.0 milestone Aug 29, 2022
@daschuer daschuer mentioned this issue Aug 29, 2022
Merged
1 task
Swiftb0y added a commit to Swiftb0y/mixxx that referenced this issue Aug 29, 2022
@Swiftb0y
fix(effects): Fix parameters of effect not showing up when not in def…
ac1a8e9 
…ault settings file

fixes mixxxdj/issues/10834
@Swiftb0y Swiftb0y mentioned this issue Aug 29, 2022
Merged
Swiftb0y added a commit to Swiftb0y/mixxx that referenced this issue Sep 5, 2022
@Swiftb0y
fix(effects): Fix parameters of effect not showing up when not in def…
2188d7f 
…ault settings file

fixes mixxxdj/issues/10834
Swiftb0y added a commit to Swiftb0y/mixxx that referenced this issue Sep 19, 2022
@Swiftb0y
fix(effects): Fix parameters of effect not showing up when not in def…
9b5c085 
…ault settings file

fixes mixxxdj/issues/10834
Swiftb0y added a commit to Swiftb0y/mixxx that referenced this issue Oct 18, 2022
@Swiftb0y
fix(effects): Fix parameters of effect not showing up when not in def…
ac766af 
…ault settings file

fixes mixxxdj/issues/10834
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effects
Projects
None yet
Milestone
2.4.0
Development

Successfully merging a pull request may close this issue.

Effects manifest defaults Swiftb0y/mixxx
1 participant
@Swiftb0y