Effects manifest defaults

[Swiftb0y]

fixes #10834

[Swiftb0y]

Actually I just realized, does this create a dangling reference? How do I force a copy here so m_effectParameterPresets takes ownership?
Does this suffice?

Suggested change

	// overwrite our parameter by taking a copy of the same parameter from `other`
	*currentParameterIt = parameterToCopy;
	// overwrite our parameter by taking a copy of the same parameter from `other`
	*currentParameterIt = EffectParameterPreset(parameterToCopy);

[daschuer]

I think the proposed version is redundant because the copy constructor is already used.

[Swiftb0y]

Thinking more about it, I'm pretty sure its the copy-assignment operator, so we should be good then.

[Be-ing]

This seems like a reasonable solution.

[Swiftb0y]

Friendly ping. Also, are we concerned about the $O(n^2)$ complexity? 3rd-party effect plugins could easily have hundreds of parameters.

[daschuer]

Oh thank you for the reminder. This has slipped through.

[daschuer]

I think the best way would be to make m_effectParameterPresets a QHash.
Than the std::find_if becomes a fast:
auto currentParameterIt = m_effectParameterPresets.find(parameterToCopy.id());

[Swiftb0y]

Can you clarify? Do you mean that we change m_effectParameterPresets to be a QHash instead of a QList? That won't work because we need to preserve the ordering of m_effectParameterPresets. What would work though is if we just built a temporary QHash on each call. What do you think?

[daschuer]

Looks already good. Do you have interest to interest to implement the suggestion?
Or should I merge this now? Than an updated comment would be nice.

[Swiftb0y]

I'd like to address the complexity issue first.

[daschuer]

Oh, yes. I have just realized that this does not work, because a stored custom sort order is lost.
Maybe we need a different approach.
A temp QHash may help to identify lost parameters.

[Swiftb0y]

Tested and ready for review. I think the new code is even simpler.

[Swiftb0y]

@daschuer merge? I tried experimenting with parallel algorithms but we need to link intel tbb for that and I don't feel like bothering with that right now.

[daschuer]

Nice Solution. LGTM thank you.