Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keyboard repeat option for certain ControlObjects #11569

Closed
ywwg opened this issue May 19, 2023 · 0 comments · Fixed by #11572
Closed

Keyboard repeat option for certain ControlObjects #11569

ywwg opened this issue May 19, 2023 · 0 comments · Fixed by #11572
Labels
confirmed control objects Issues and bugs specifically in regard to mixxx `ControlObjects` feature keyboard usability

Comments

@ywwg
Copy link
Member

ywwg commented May 19, 2023 •
edited
Loading

Feature Description

It would be helpful if some control objects would be activated repeatedly if a keyboard control is held down. These include:

  • beatjump, for seeking quickly through a track
  • beats_adjust_* and beats_translate_* (this is where I want it the most, adjusting grids is very slow going tap tap tap tap tap tap right now)
  • loop_double/halve
  • rate_perm_ controls

To prevent accidental repetition we would implement this the standard way, with a long delay before first repetition, and then a shorter delay between each subsequent repetition.

It would be a pretty small change to add an option to controlobject like setKeyboardRepeatable(bool) and then access that value in keyboardeventfilter and set up a small hashtable of timers (in case multiple keys are held) to manage the repetition of control object signal emissions.
@ywwg ywwg added feature usability keyboard control objects Issues and bugs specifically in regard to mixxx `ControlObjects` labels May 19, 2023
ywwg added a commit to ywwg/mixxx that referenced this issue May 20, 2023
@ywwg
Create option for control objects to be issued repeatedly if a keyboa…
9092350 
…rd key is held.

Fixes mixxxdj#11569

Applies to:
* beats_adjust_faster, beats_adjust_slower
* beats_translate_earlier, beats_translate_later
* beat_next, beat_prev
* beatjump_size_halve, beatjump_size_double
* beatjump_forward, beatjump_backward
* loop_halve, loop_double
* beatjump_X_foward, beatjump_X_backward
* rate_perm_down, rate_perm_down_small, rate_perm_up, rate_perm_up_small
@ywwg ywwg mentioned this issue May 20, 2023
Merged
ywwg added a commit to ywwg/mixxx that referenced this issue May 20, 2023
@ywwg
Create option for control objects to be issued repeatedly if a keyboa…
b76dad5 
…rd key is held.

Fixes mixxxdj#11569

Applies to:
* beats_adjust_faster, beats_adjust_slower
* beats_translate_earlier, beats_translate_later
* beat_next, beat_prev
* beatjump_size_halve, beatjump_size_double
* beatjump_forward, beatjump_backward
* loop_halve, loop_double
* beatjump_X_foward, beatjump_X_backward
* rate_perm_down, rate_perm_down_small, rate_perm_up, rate_perm_up_small
ronso0 pushed a commit to ronso0/mixxx that referenced this issue Dec 29, 2023
@ywwg @ronso0
Create option for control objects to be issued repeatedly if a keyboa…
a5737d9 
…rd key is held.

Fixes mixxxdj#11569

Applies to:
* beats_adjust_faster, beats_adjust_slower
* beats_translate_earlier, beats_translate_later
* beatjump_size_halve, beatjump_size_double
* beatjump_forward, beatjump_backward
* loop_halve, loop_double
* beatjump_X_foward, beatjump_X_backward
* rate_perm_down, rate_perm_down_small, rate_perm_up, rate_perm_up_small
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
confirmed control objects Issues and bugs specifically in regard to mixxx `ControlObjects` feature keyboard usability
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Create option for control objects to be issued repeatedly if a keyboard key is held. ywwg/mixxx
2 participants
@ywwg @daschuer