Create option for control objects to be issued repeatedly if a keyboard key is held. #11572
Conversation
…rd key is held. Fixes mixxxdj#11569 Applies to: * beats_adjust_faster, beats_adjust_slower * beats_translate_earlier, beats_translate_later * beat_next, beat_prev * beatjump_size_halve, beatjump_size_double * beatjump_forward, beatjump_backward * loop_halve, loop_double * beatjump_X_foward, beatjump_X_backward * rate_perm_down, rate_perm_down_small, rate_perm_up, rate_perm_up_small
use std::any_of instead of old foreach Co-authored-by: Swiftb0y <12380386+Swiftb0y@users.noreply.github.com>
|
Shouldn't this apply to all potmeter _up, _down, _up_small & _down_small controls? |
ronso0
added
keyboard
control objects
|
yup I can do that |
|
The code looks good for me and I can confirm the issue. I just wonder if this is a good approach, because until now, the keyboard keys are treated very similar as the controller keys and as GUI buttons. A press event becomes a NoteOn and the release events a NoteOff. The keyboard repetition has been intentionally disabled to keep that model working. After merge, a keyboard button has a special exclusive behavior. I think form this point of view a repetition logic inside the CO, that works independent from the source of the control event is the preferred solution. The user does probably not understand that we rely on the OS's repetition settings, that is only available for keyboards A case where these settings are miss-configured for Mixxx might be another setting. Do you have interest to make this feature also work for controller and GUI buttons? |
I see what you mean -- if perhaps someone has linked the beatjump parameter to a button on a controller, they might want this behavior. But I would prefer to write features in response to concrete need rather than hypothetical situations or abstract logical notions of consistency. In my experience I have never wanted this repeat behavior on a controller nor have I seen a feature request for it -- beatjump is usually bound to a clicking knob that is easy to spin. I would want to see a concrete example where this might be a useful feature before coding it. Whereas, when I am gridding and preparing my library with just my keyboard, or doing keyboard-only mixing, I definitely have wanted this keyboard repeat behavior, so I wanted to write this. |
|
Umm, why did this go to main? |
backport Keyboard repeat #11572 to 2.4
Fixes #11569
Applies to: