Import from Rhythmbox playlist fix #11661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swiftb0y
reviewed
Jun 15, 2023
Comment on lines
-94
to
+95
| BaseSqlTableModel* RhythmboxFeature::getPlaylistModelForPlaylist(const QString& playlist) { | ||
| BaseExternalPlaylistModel* pModel = new BaseExternalPlaylistModel( | ||
| this, m_pLibrary->trackCollections(), | ||
| "mixxx.db.model.rhythmbox_playlist", | ||
| "rhythmbox_playlists", | ||
| "rhythmbox_playlist_tracks", | ||
| m_trackSource); | ||
| std::unique_ptr<BaseSqlTableModel> | ||
| RhythmboxFeature::createPlaylistModelForPlaylist(const QString& playlist) { |
There was a problem hiding this comment.
just to make sure I understand the fix. The issue was basically that an oversight during refactoring resulted in the wrong member function being called?
There was a problem hiding this comment.
Yes, the getPlaylistModelForPlaylist() is no longer called, instead the default base class implementation is used returning null.
Swiftb0y
approved these changes
Jun 15, 2023
|
I can. And the coding mistake was obvious. |
|
Sure... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression since #11230 and Mixxx 2.3.4
that bulk importing tracks from playlists was broken.