CO Renaming (Pt. 2): Skin Controls #11996
Conversation
Holzhaus
added
code quality
control objects
We can't, Also, only |
This allows testing them separately from the `CoreServices`.
|
Alright, I moved the CO creation into a separate class and added a test for the |
src/uicontrols.cpp
Outdated
| ConfigKey(QStringLiteral("[VinylControl]"), | ||
| QStringLiteral("show_vinylcontrol")), |
There was a problem hiding this comment.
controlpickermenu.cpp still uses VINYL_PREF_KEY
Shouldn't we move this to the Skin group as well?
There was a problem hiding this comment.
Sounds reasonable. The same applies to the other COs in uicontrols.cpp.
I only renamed the COs that had to be renamed, but if we want to make stuff consistent, I would propose this:
| Old Name | New Name |
|---|---|
[EffectRack1],show |
[Skin],show_effectrack |
[Library],show_coverart |
[Skin],show_library_coverart |
[Microphone],show_microphone |
[Skin],show_microphone |
[PreviewDeck],show_previewdeck |
[Skin],show_previewdeck |
[Samplers],show_samplers |
[Skin],show_samplers |
[VinylControl],show_vinylcontrol |
[Skin],show_vinylcontrol |
There was a problem hiding this comment.
Yeah, sure, go ahead! IMO it doesn't make much sense binding skin controls to these engine groups.
I didn't dare to propose changing all those atm to not slow down your renaming rush ; )
There was a problem hiding this comment.
Yeah, sure, go ahead!
If everyone agrees of course!
There was a problem hiding this comment.
Done. Note that used show_microphones and show_previewdecks (with an additional s at the end) to match the plural in show_samplers. Our current skins show multiple microphones anyway, so it fits better. Only a single preview deck is used, but If some skin designer wants to use multiple, why not (we support 4 IIRC)?
This PR is part of the ongoing effort to remove offensive language from the Mixxx codebase (#11931).
This takes care of the skin control renamings discussed in #11960 (comment).
[Master],maximize_library[Skin],show_maximized_library[Master],show_mixer[Skin],show_mixer[Master],skin_settings[Skin],show_settings