Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(skincontrols): Rename show_previewdecks to show_preview_decks #12007

Merged
merged 1 commit into from
Sep 23, 2023

Conversation

Holzhaus
Copy link
Member

This more consistent with the [App],num_preview_decks CO. Sorry, I should have checked this beforehand and done this as part of #11996.

This more consistent with the `[App],num_preview_decks` CO.
@Holzhaus Holzhaus added the control objects Issues and bugs specifically in regard to mixxx `ControlObjects` label Sep 21, 2023
Copy link
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this need an alias?

@Swiftb0y
Copy link
Member

should this go into 2.4?

@Holzhaus Holzhaus changed the base branch from main to 2.4 September 21, 2023 17:30
@Holzhaus
Copy link
Member Author

should this go into 2.4?

Oops, I changed the base branch.

@Holzhaus
Copy link
Member Author

does this need an alias?

No, I suppose the number of people who used this undocumented control since the PR was merged is 0.

@Holzhaus
Copy link
Member Author

Merge?

Copy link
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, thank you.

@Swiftb0y Swiftb0y merged commit 6caebd2 into mixxxdj:2.4 Sep 23, 2023
13 checks passed
@Holzhaus
Copy link
Member Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality control objects Issues and bugs specifically in regard to mixxx `ControlObjects` skins ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants