Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve rate_up/down tooltips, pitch vs. speed #12590

Merged
merged 4 commits into from
Mar 12, 2024
Merged

Improve rate_up/down tooltips, pitch vs. speed #12590

merged 4 commits into from
Mar 12, 2024

Commits on Jan 18, 2024

  1. Correct inaccurate tooltip help

    The tooltip help regarding the playback rate change buttons stated that
    those raise/lower pitch.
    
    If keylock is disabled, this is true, though incomplete, since the
    buttons also affect playback speed.
    If keylock is enabled, this is false, since pitch is left unchanged, and
    only playback speed changes.
    
    This commit replaces the tooltip text about pitch change with text about
    playback speed. It also copies the clarification:
    "(affects both the tempo and the pitch). If keylock is enabled, only the
    tempo is affected."
    over from the Speed Control fader tooltip, to prevent further confusion.
    glocq committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    f9cc915 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2024

  1. Apply suggestions from code review

    Co-authored-by: ronso0 <ronso0@mixxx.org>
    glocq and ronso0 authored Mar 12, 2024
    Configuration menu
    Copy the full SHA
    079e3ff View commit details
    Browse the repository at this point in the history
  2. Break excessively long lines

    glocq committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    9092286 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    64e1677 View commit details
    Browse the repository at this point in the history