Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve rate_up/down tooltips, pitch vs. speed #12590

Merged
merged 4 commits into from
Mar 12, 2024
Merged

Improve rate_up/down tooltips, pitch vs. speed #12590

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f9cc915
Correct inaccurate tooltip help
glocq Jan 18, 2024
079e3ff
Apply suggestions from code review
glocq Mar 12, 2024
9092286
Break excessively long lines
glocq Mar 12, 2024
64e1677
Use a common QString to avoid repetition
glocq Mar 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 28 additions & 12 deletions src/skin/legacy/tooltips.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,28 +324,44 @@ void Tooltips::addStandardTooltips() {
<< tr("Manual: Sets how much to reduce the music volume, when talkover is activated regardless of volume of microphone inputs.");

QString changeAmount = tr("Change the step-size in the Preferences -> Decks menu.");
QString pitchAffected = tr("If keylock is disabled, pitch is also affected.");

add("rate_perm_up_rate_perm_up_small")
<< tr("Raise Pitch")
<< QString("%1: %2").arg(leftClick, tr("Sets the pitch higher."))
<< QString("%1: %2").arg(rightClick, tr("Sets the pitch higher in small steps."))
<< tr("Speed Up")
<< QString("%1: %2").arg(leftClick,
tr("Raises the track playback speed (tempo)."))
<< pitchAffected
<< QString("%1: %2").arg(
rightClick, tr("Raises playback speed in small steps."))
<< changeAmount;

add("rate_perm_down_rate_perm_down_small")
<< tr("Lower Pitch")
<< QString("%1: %2").arg(leftClick, tr("Sets the pitch lower."))
<< QString("%1: %2").arg(rightClick, tr("Sets the pitch lower in small steps."))
<< tr("Slow Down")
<< QString("%1: %2").arg(leftClick,
tr("Lowers the track playback speed (tempo)."))
<< pitchAffected
<< QString("%1: %2").arg(
rightClick, tr("Lowers playback speed in small steps."))
<< changeAmount;

add("rate_temp_up_rate_temp_up_small")
<< tr("Raise Pitch Temporary (Nudge)")
<< QString("%1: %2").arg(leftClick, tr("Holds the pitch higher while active."))
<< QString("%1: %2").arg(rightClick, tr("Holds the pitch higher (small amount) while active."))
<< tr("Speed Up Temporarily (Nudge)")
<< QString("%1: %2").arg(leftClick,
tr("Holds playback speed higher while active (tempo)."))
<< pitchAffected
<< QString("%1: %2").arg(rightClick,
tr("Holds playback speed higher (small amount) while "
"active."))
<< changeAmount;

add("rate_temp_down_rate_temp_down_small")
<< tr("Lower Pitch Temporary (Nudge)")
<< QString("%1: %2").arg(leftClick, tr("Holds the pitch lower while active."))
<< QString("%1: %2").arg(rightClick, tr("Holds the pitch lower (small amount) while active."))
<< tr("Slow Down Temporarily (Nudge)")
<< QString("%1: %2").arg(leftClick,
tr("Holds playback speed lower while active (tempo)."))
<< pitchAffected
<< QString("%1: %2").arg(rightClick,
tr("Holds playback speed lower (small amount) while "
"active."))
<< changeAmount;

add("filterLow")
Expand Down