Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS packaging: Add Info.plist, launch screen and app icon #12676

Merged
merged 4 commits into from
Jan 29, 2024

Conversation

fwcd
Copy link
Member

@fwcd fwcd commented Jan 28, 2024

This adds packaging assets used by the iOS app:

  • A borderless rectangular app icon, based on Add a Big Sur-style rounded rectangle icon on macOS #4545
    • Like for the macOS icon, a script is provided to regenerate the PNG (which is actually used) from the SVG
  • An Info.plist that e.g. also provides the permission to view Mixxx's sandbox directories from the iOS files app
  • A launch screen that displays the Mixxx logo (which is included as PDF, the format iOS expects) before any UI is loaded:

@daschuer
Copy link
Member

Did you consider the option to not add extra icons for iOS, but link existing? This will reduce some maintenance in future.

@fwcd
Copy link
Member Author

fwcd commented Jan 29, 2024

Yeah, the problem is that iOS needs a borderless icon (as opposed to macOS), therefore we need a separate one. Technically we could use the bordered one, but the App Store generally disallows transparent icons and if iOS changes the corner radius again (they did that back in iOS 7 IIRC), the icon would look strange again.

@JoergAtGithub
Copy link
Member

LGTM! Thank you!

@JoergAtGithub JoergAtGithub merged commit 157191c into mixxxdj:main Jan 29, 2024
12 checks passed
@fwcd fwcd deleted the ios-packaging branch January 29, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants