Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Big Sur-style rounded rectangle icon on macOS #4545

Merged
merged 1 commit into from
Nov 29, 2021

Conversation

fwcd
Copy link
Member

@fwcd fwcd commented Nov 28, 2021

Fixes https://bugs.launchpad.net/mixxx/+bug/1952532.

This PR adds a macOS Big Sur-style icon for macOS, following the conventions outlined in Apple's Human Interface Guidelines:

mixxx_macos

With this icon, Mixxx looks more 'at home' with other macOS apps:

new_dock
old_dock

The new icon is provided both as an SVG and as corresponding ICNS files.

@Holzhaus Holzhaus added changelog This PR should be included in the changelog packaging/installer labels Nov 28, 2021
@Holzhaus Holzhaus added this to the 2.4.0 milestone Nov 28, 2021
@ronso0
Copy link
Member

ronso0 commented Nov 28, 2021

Thank you!
The Human Interface Guidelines doesn't mention SVG, though it works, and it explicitely states "Don’t provide app icons in ICNS or JPEG format."
Can you elaborate?

Copy link
Member

@ronso0 ronso0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few issues regarding hidden objects.
This is nit-picking, I know, but when working with image ressources I often noticed we drag 'dead freight' along, so let's clean that up if we add a new file.

res/images/icons/scalable/apps/mixxx_macos.svg Outdated Show resolved Hide resolved
res/images/icons/scalable/apps/mixxx_macos.svg Outdated Show resolved Hide resolved
@fwcd
Copy link
Member Author

fwcd commented Nov 28, 2021

I chose SVG as a source format to have a scalable vector version of the icon, just like the existing one. The SVG version is only for development though, the icon that is actually used for the app bundle is a rendered/rasterized version, i.e. the ICNS files.

The motivation for using ICNS for now is that the existing icon uses it, thereby making it a drop-in replacement for now. Updating to an asset bundle would be something I'd rather put in a separate PR since it might require changes to the build/packaging process on macOS.

@ronso0
Copy link
Member

ronso0 commented Nov 28, 2021

Thanks.
Btw I think when you're done with the clean-up you can squash your commits into one update macOS app icon, rounded rectangle

- Add initial macOS Big Sur icon draft
- Replace macOS icon lens flare with brighter gradient
- Add drop shadow to macOS icon
- Update macOS ICNS files
- Remove hidden layers from new macOS icon
@fwcd
Copy link
Member Author

fwcd commented Nov 28, 2021

The branch should now be rebased, squashed and ready for merge.

@Holzhaus Holzhaus requested a review from ronso0 November 29, 2021 09:30
@ronso0
Copy link
Member

ronso0 commented Nov 29, 2021

I couldn't extract all PNG from the icns, but @foss- helped verifying those.

LGTM Thank you @fwcd!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog This PR should be included in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants