-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a Big Sur-style rounded rectangle icon on macOS #4545
Conversation
Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few issues regarding hidden objects.
This is nit-picking, I know, but when working with image ressources I often noticed we drag 'dead freight' along, so let's clean that up if we add a new file.
I chose SVG as a source format to have a scalable vector version of the icon, just like the existing one. The SVG version is only for development though, the icon that is actually used for the app bundle is a rendered/rasterized version, i.e. the ICNS files. The motivation for using ICNS for now is that the existing icon uses it, thereby making it a drop-in replacement for now. Updating to an asset bundle would be something I'd rather put in a separate PR since it might require changes to the build/packaging process on macOS. |
Thanks. |
8dc2c9f
to
7c9ea18
Compare
- Add initial macOS Big Sur icon draft - Replace macOS icon lens flare with brighter gradient - Add drop shadow to macOS icon - Update macOS ICNS files - Remove hidden layers from new macOS icon
7c9ea18
to
fb58995
Compare
The branch should now be rebased, squashed and ready for merge. |
Fixes https://bugs.launchpad.net/mixxx/+bug/1952532.
This PR adds a macOS Big Sur-style icon for macOS, following the conventions outlined in Apple's Human Interface Guidelines:
With this icon, Mixxx looks more 'at home' with other macOS apps:
The new icon is provided both as an SVG and as corresponding ICNS files.