LV Mix EQ: Fix pops when enabling #13073
Conversation
…fixed pops after re-enabling.
|
I have almost no clue what's going on here. Can this huge commented code block be removed? |
|
I can not reproduce the bug anymore so it can't even test if this fixes it, sorry 🤷 |
|
Ok, I can confirm that the pop can only be heared by a chance. I happens only after a toggle cycle of enabling and disabling the EQ as effect. |
| m_oldLow(1.0), | ||
| m_oldMid(1.0), | ||
| m_oldLow(0.0), | ||
| m_oldMid(0.0), |
There was a problem hiding this comment.
In our LV mix, the high part is carrying the dry stream.
So this is an obvious fix to ramp from dry after initializing.
| m_oldLow = 0.0; | ||
| m_oldMid = 0.0; | ||
| m_oldHigh = 1.0; | ||
| m_rampHoldOff = LVMixEQEffectGroupStateConstants::kRampDone; |
There was a problem hiding this comment.
This is that actual fix:
This fixes the missing tracking if the old values after ramping to unity. After the fix it will ramp from unity when enabling again, before it rams from the old knob positions before disabling which may create the pop.
|
I assume it's correct that this is assigned to 2.4.1, please rebase so we can merge it. |
|
Done. |
|
Thanks for the quick fix! |
This fixes #13055