Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LV Mix EQ: Fix pops when enabling #13073

Merged
merged 1 commit into from
May 1, 2024
Merged

LV Mix EQ: Fix pops when enabling #13073

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/effects/backends/builtin/lvmixeqbase.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ class LVMixEQEffectGroupState : public EffectState {
public:
explicit LVMixEQEffectGroupState(const mixxx::EngineParameters& engineParameters)
: EffectState(engineParameters),
m_oldLow(1.0),
m_oldMid(1.0),
m_oldLow(0.0),
m_oldMid(0.0),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In our LV mix, the high part is carrying the dry stream.
So this is an obvious fix to ramp from dry after initializing.

m_oldHigh(1.0),
m_rampHoldOff(LVMixEQEffectGroupStateConstants::kRampDone),
m_oldSampleRate(engineParameters.sampleRate()),
Expand Down Expand Up @@ -216,6 +216,11 @@ class LVMixEQEffectGroupState : public EffectState {
m_oldHigh,
1.0,
numSamples);

m_oldLow = 0.0;
m_oldMid = 0.0;
m_oldHigh = 1.0;
m_rampHoldOff = LVMixEQEffectGroupStateConstants::kRampDone;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is that actual fix:

This fixes the missing tracking if the old values after ramping to unity. After the fix it will ramp from unity when enabling again, before it rams from the old knob positions before disabling which may create the pop.

}

/*
Expand Down