Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preferences: apply only in slotApply() #13302

Merged
merged 3 commits into from
Jun 3, 2024
Merged

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented May 29, 2024

one more step to fix #7440

Is there a specific reason to instantly apply ReplayGain settings (Normalization)?

@ronso0 ronso0 added this to the 2.5.0 milestone May 29, 2024
@daschuer
Copy link
Member

Is there a specific reason to instantly apply ReplayGain settings (Normalization)?

Yes. You may play a track with either ReplayGain Applied or without and adjust the Gain values watching the VU Meters.
If we Apply() with an extra button changes are applied without a gentle ramp. There is a Risk to blow your speakers because of insane gains. Maybe it is a good idea to place a note at the slider box that output is immediately affected.
The the jump problem already applies to the checkbox. This should probably be covered in the note.

@ronso0
Copy link
Member Author

ronso0 commented May 30, 2024

That makes sense. I would rather have a checkbox “Apply settings immediately”, but I don't feel like refactoring this it at the moment.
I'll revert and only keep the groupbox / tabstop tweaks.

Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you.

@daschuer daschuer merged commit 4535333 into mixxxdj:2.5 Jun 3, 2024
13 checks passed
@ronso0 ronso0 deleted the pref-opti-apply branch June 3, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants