Scrolling waveform using SceneGraph in QML #13470
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acolombier
changed the title
|
This PR is marked as stale because it has been open 90 days with no activity. |
github-actions
bot
added
stale
|
Note that this is still being actively worked on with @m0dB and myself! |
…Node for end of track
…and material for mixxx and rendergraph examples
…he opengl or the scenegraph backend.
un-name unused argument Co-authored-by: Swiftb0y <12380386+Swiftb0y@users.noreply.github.com>
Co-authored-by: Daniel Schürmann <daschuer@mixxx.org>
Co-authored-by: Swiftb0y <12380386+Swiftb0y@users.noreply.github.com>
…s, so i can start porting some to geometrynode
…ta between opengl and scenegraph
…odes, add GeometryNode::markDirtyGeometry() and GeometryNode::markDirtyMaterial()
…ed engine class from scenegraph, get context from m_waveformRenderer, various cleanups
acolombier
force-pushed
the
feat/qml-scrolling-waveform-with-sg
branch
2 times, most recently
from
5ec00bf
to
d16b1dc
Compare
acolombier
force-pushed
the
feat/qml-scrolling-waveform-with-sg
branch
from
d16b1dc
to
23f331f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a rebase of @m0dB's
qml_scrolling_waveformon the latest mainThe waveform rendering approach should provided better result in the long run and should integrate with the new
allshaderapproach.Currently, the waveform rendering logic which happen in
QmlWaveformDisplay::updatePaintNodeis duplicated (or rather strongly inspired) from the RGB allshader rendering. A "definition of ready" for this PR would be to have some kind of compatibility layer/integration to reuse the rendering logic define inallshaderand should support at least one waveform type logic (e.gRGB)Depends on #13599