fix: support for new WaveformData struct in shaders #13474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this does fix the offset / half-waveform issue, but it does not fix the crash when changing preferences (#13471) |
ywwg
approved these changes
Jul 15, 2024
|
Thanks for the review @ywwg - sorry did that between two meetings, will grab the time to fix the comments Note that the Wayland issue is not related to stem nor waveform changes. |
acolombier
force-pushed
the
fix/waveform-shader-support-for-new-struct
branch
from
85a4e2f
to
717b633
Compare
|
@ywwg I amended the commit - feel free to merge when ready :) |
|
hmm it looks like this didn't actually work right, it seems to be off by a factor of 2 by length. This makes it seem to line up with the beat grid, but if you fast forward to the end of the track, it doesn't |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13472
As part of the newly introduce
Waveform-6.0format, the waveform data now allocates space for stem information. This PR fixes the rendering issues with shaders, by offsetting the waveform data.Going forward, we may consider add some more advanced logic to use the stem data if available, but this will require feeding more attribute to GLSL, such as stem gain.
@daschuer @ywwg would appreciate a test if you can :)