-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add float widget to control stem UI #13515
Conversation
or in a deck over the cover art? |
Appreciate the feedback @JoergAtGithub and definitely agree with the statement! I also feel like that floating windows approach is likely to offer a very poor support across some of the more exotic platform we are trying to introduce (WASM, Android, iOS...) When it comes to having the control somewhere else as you suggested, my only fear is - how do we make that valid for other themes? Your suggestion sounds find for a LateNight, but not sure how we would make that work on Tango, Deere and Shade. Sadly @Eve00000, putting the control over the spinny suffers from the same limitation: these are sub-rendered section, dedicated to an isolated OpenGL window, so drawing a custom widget required either the same "hack" (floating window) or custom OpenGL rendering, but then widgets won't be interactive. I would suggest we keep this PR open, so users still have a way to add controls to perform some test and development around stem, but otherwise, I would suggest we keep the stem feature CO-only, so only accessible via controllers and QML, as originally scoped (Actually, QML wasn't, so it is bonus here :D). [Hot Take] |
I wrote this on Zulip but evidently the connection between Github and Zulip is not a bijection so i copied it here. Ok, sad indeed. Without visual controls… that means without viewing the chosen effect to. Last week I discovered and plaed around with the qml (mixxx.exe —qml)interface too. I lust admit I have no clue of the work needed to finish it. I know there’s a designer in the house wit an incredible knowledge of the gui and the Lixxx-code. |
The waveform will remain as is, with the per-stem signal!
Finger in the air, I would say it's about 50% done. @m0dB has started preparing some solid design for handling waveform rendering, and there is also some great PoC waiting to be continued on the library from Maarten, Jan and I. Another suggesting could be to keep that floating widget under a a feature flag? (e.g settings, command line argument) |
I think that would be a nice option to cover a 'step in' period |
May I ask what the parameters for this calculation are? #contributors and how much time dedicated per day / week / month only to this project? What is best case and worst case scenario? What could help / what could go wrong? (SWOT) For me to compare, how much time have you already spend on the stem-project? |
b1839f1
to
3239558
Compare
3239558
to
67b2d61
Compare
Closing in favour of #3537 |
This PR adds a widget allowing to control stems from the UI.
Due to how waveform are rendered, this widget had a to be a floating widget, which is making it quite unreliable, and thus is likely never to make it to
main
.This PR is mostly hear as reference for anyone willing to test stem on legacy UI.
Note that stem can already be controlled on QML UI