-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hercules P32 mapping: more accurate headmix control #3537
Hercules P32 mapping: more accurate headmix control #3537
Conversation
423c7ca
to
44da75f
Compare
Documentation PR: #3537 |
@Be-ing don't you own a P32? Merge? |
Yes, I have not yet tested this. I am doubtful it should be merged. |
From my point of view, the today head mix control is not accurate at all (9 possible positions vs. 33 in this PR, and moving from full cue to full mix is still available with one hand movement). I found it so much easier to match the headphone preview I need as it. @Be-ing Can you please explain your doubts? |
Originally I intentionally made this coarse because it's not important to have a smooth crossfade in your headphones that the audience doesn't hear. Generally, I'd think most users would only want this in one of three positions: fully left, center, or fully right. So I thought it was better to make it easy to switch between those states quickly. After testing this again, I feel that the current coarseness is a bit awkward and unexpected. But I think 0.625 is too fine. How about 0.1? |
Interesting ; I am new in DJing and I found this feature (firstly on a Numark Mixtrack II Pro, where a potentiometer is dedicate to) very important to beat match, pre-set EQs & co. well in every possible environments :o
* I naively tried only I don't feel it awkward but I will give a try with |
The head mix is 4 times more accurate now.
44da75f
to
36fc3bd
Compare
Change made. |
@Be-ing please don't merge stuff without also merging the corresponding manual PR: mixxxdj/manual#342 |
I didn't realize there was a manual PR for this because it was not linked here nor do I think this tiny change needed one. |
We should track changes using the |
The headmix is 4 times more accurate as it.
I feel it very handy :)