Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numark NS6II Controller Mapping #2049

Closed
wants to merge 11 commits into from
Closed

Conversation

Swiftb0y
Copy link
Member

@Swiftb0y Swiftb0y commented Mar 4, 2019

It is mostly completed / ready for review.
However, I wasn't able to test it yet to the required extend.
Features:

Known Issues:

  • init function missing serato get status sysex msg
  • Time displayed on display dependent on duration*playposition (instead of rate-adjusted time_elapsed/time_remaining) (won't fix; I'll consider it while reworking the mapping with QJSEngine)
  • NS6II and Mixxx have different crossfader curves (same issue with serato so this might be tolerable)
  • slider_pitch soft takeover leds flicker when the slider is moved quickly (L658; requires more complicated solution which I haven't found yet)
  • shutdown code still missing
  • documentation missing
  • cont_pad_mode_selector Led pad index weirdness when two buttons are pressed twice
  • Development notes and jshint config still present.
  • print debugging statements still present.

Related/Dependent PRs:

@Holzhaus Holzhaus added this to the 2.3.0 milestone Jan 20, 2020
@Holzhaus
Copy link
Member

What's the status of this PR?

@Swiftb0y
Copy link
Member Author

Stalled. I decided I will rewrite it after #1795 got merged (and we possibly adapted the components library to ES7 as well).
I guess it makes sense to close the PR for now.

@Swiftb0y Swiftb0y closed this Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants