Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make controller shutdown easier for components JS based mappings. #2052

Merged
merged 1 commit into from
Sep 1, 2019
Merged

Make controller shutdown easier for components JS based mappings. #2052

merged 1 commit into from
Sep 1, 2019

Conversation

Swiftb0y
Copy link
Member

@Swiftb0y Swiftb0y commented Mar 5, 2019 •
edited
Loading

TODO:

  • Document on Wiki

@Swiftb0y Swiftb0y mentioned this pull request Mar 14, 2019
Closed
17 tasks
@uklotzde uklotzde added this to the 2.3.0 milestone Apr 24, 2019
@Swiftb0y
Copy link
Member Author

Swiftb0y commented Aug 1, 2019

I just added this sentence to the ComponentContainer documentation:

  • shutdown: Iterate over all Components and call their shutdown methods. The Button is the only component with a predefined shutdown method. All other components have to be implemented manually.

is this sufficient as documentation?

@Be-ing
Copy link
Contributor

Be-ing commented Sep 1, 2019

LGTM thanks for this nice little addition.

@Be-ing Be-ing merged commit f3395e8 into mixxxdj:master Sep 1, 2019
@Swiftb0y Swiftb0y mentioned this pull request Apr 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Swiftb0y @Be-ing @uklotzde