User right group for "ViewMenu_ShowSkinSettings", fixes lp1851993.

[daschuer]

Fixes https://bugs.launchpad.net/mixxx/+bug/1851993

[daschuer]

This is also a 2.2 issue. Need to rebase.

[Holzhaus]

I this a MacOS-only fix or is the issue reproducable on other OSes, too? I'd test your PR, but I have no Mac.

[ronso0]

At lest on linux it works perfectly without this PR: shortcut is displayed Ctrl + 1 and it toggles the menu.

[daschuer]

Yes, this works in my case as well. The issue that is fixed here is that there are

[KeyboardShortcuts], ViewMenu_ShowSkinSettings entries in the keyboard mapping files:

mixxx/res/keyboard/de_DE.kbd.cfg

Line 148 in fcbf2d0

ViewMenu_ShowSkinSettings Ctrl+1

Maybe they are used an MacOs and the default fails for some reason.

[Holzhaus]

Hmm, I have the issue of missing keyboard shortcuts on Linux as well (even with this PR applied).
The problems seems to be locale-dependent:

With LANG=de_DE ./mixxx the problem persists:

With LANG=C ./mixxx the problem is gone:

[ronso0]

At lest on linux it works perfectly without this PR: shortcut is displayed Ctrl + 1 and it toggles the menu.

Aha. I use the system locale, which is en_US

[daschuer]

In the German version the short cuts should be translated as well.
"Strg+1"

[esbrandt]

In the German version the short cuts should be translated as well.

Hmm, they already are translated
https://www.transifex.com/mixxx-dj-software/mixxxdj/translate/#de/mixxx2-3/153124672?q=text%3Actrl.

Could it be, that not the translated shortcuts from res/translations/*.ts, but from the keyboard shortcut file res/keyboard/*.kbd.cfg are displayed? We have contradicting shortcuts in

mixxx/res/keyboard/de_DE.kbd.cfg

Lines 148 to 154 in a7a7938

	ViewMenu_ShowSkinSettings Ctrl+1
	ViewMenu_ShowMicrophone Ctrl+2
	ViewMenu_ShowVinylControl Ctrl+3
	ViewMenu_ShowPreviewDeck Ctrl+4
	ViewMenu_ShowEffects Ctrl+5
	ViewMenu_ShowCoverArt Ctrl+6
	ViewMenu_MaximizeLibrary Space

I have never noticed on macOS, because there is always the Command key (⌘) on display, no matter the language .

[Holzhaus]

Could it be, that not the translated shortcuts from res/translations/*.ts, but from the keyboard shortcut file res/keyboard/*.kbd.cfg are displayed? We have contradicting shortcuts in

mixxx/res/keyboard/de_DE.kbd.cfg

Lines 148 to 154 in a7a7938

	ViewMenu_ShowSkinSettings Ctrl+1
	ViewMenu_ShowMicrophone Ctrl+2
	ViewMenu_ShowVinylControl Ctrl+3
	ViewMenu_ShowPreviewDeck Ctrl+4
	ViewMenu_ShowEffects Ctrl+5
	ViewMenu_ShowCoverArt Ctrl+6
	ViewMenu_MaximizeLibrary Space

Bingo, running this command fixed the issue for me:

$ sed -i 's/ViewMenu_ShowSamplers Ctrl+1/ViewMenu_ShowSkinSettings Ctrl+1/' res/keyboard/*.kbd.cfg

[daschuer]

Does this mean we can merge this now?

[Holzhaus]

As I said, the issue is only fixed if you fix the keyboard shortcuts in res/keyboard/*.kbd.cfg. For some reason, Ctrl+1 is mapped to ShowSamplers instead of ShowSkinSettings there.

[daschuer]

Ah got it. I did not understand it, because it was already fixed in master
4db75b6

[daschuer]

OK, kbd.cfg files are fixed now.

[Holzhaus]

I tested with LANG=cs_CZ, da_DK, de_CH, de_DE, el_GR, en_US, es_ES, fi_FI, fr_CH, fr_FR, it_IT and ru_RU and the Ctrl+1 shortcut shows up and works with all of them. LGTM.

[uklotzde]

Also, LGTM.

@daschuer Could you please add a line in the changelog in #1789?

[uklotzde]

The branch was targeted to master!!

[uklotzde]

Follow-up #2372